Comment 13 for bug 1069808

Hi Oleg,

I already tried to generate a "pull request" for the version control system at launchpad.net but I have never used the bzr client before and thus failed. Now that you have confirmed that my version works for you, I might give it another go...

André

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Oleg V. Kozlyuk
Sent: Dienstag, 15. Januar 2013 09:17
To: André Radke
Subject: Re: [Bug 1069808] Re: Compatibility with 2.1.x

Hi,

unfortunately, leading underscores were not the problem here... I've
tried them in all combination (_avatar.html.erb, avatar.html.erb,
_avatar.erb.html, etc.)

Your version is working, however, many thanks!!!
I'll compare the file structure later today - need to figure out how
to correctly use "patch" myself. However, the version looks good.
Maybe you can send a "pull request" to Luca Pireddu with your changes?

2013/1/15 André Radke <email address hidden>:
> I created my patch with "bzr diff". I'm not sure if the patch utility
> will handle the file renaming properly. Anyway, here's what the file
> hierarchy should look like after applying my patch:
>
> redmine_local_avatars/README.rd
> redmine_local_avatars/app/views/hooks/redmine_local_avatars/_view_my_account_contextual.html.erb
> redmine_local_avatars/app/views/my/avatar.html.erb
> redmine_local_avatars/app/views/users/_avatar.html.erb
> redmine_local_avatars/config/routes.rb
> redmine_local_avatars/config/locales/bg.yml
> redmine_local_avatars/config/locales/de.yml
> redmine_local_avatars/config/locales/en.yml
> redmine_local_avatars/config/locales/es.yml
> redmine_local_avatars/config/locales/fr.yml
> redmine_local_avatars/config/locales/it.yml
> redmine_local_avatars/config/locales/pt-BR.yml
> redmine_local_avatars/config/locales/ru.yml
> redmine_local_avatars/config/locales/zh-TW.yml
> redmine_local_avatars/config/locales/zh.yml
> redmine_local_avatars/init.rb
> redmine_local_avatars/lib/account_controller_patch.rb
> redmine_local_avatars/lib/application_helper_avatar_patch.rb
> redmine_local_avatars/lib/local_avatars.rb
> redmine_local_avatars/lib/my_controller_patch.rb
> redmine_local_avatars/lib/redmine_local_avatars/hooks.rb
> redmine_local_avatars/lib/users_avatar_patch.rb
> redmine_local_avatars/lib/users_controller_patch.rb
> redmine_local_avatars/lib/users_helper_avatar_patch.rb
>
> It's apparently important to get the leading underscores right in
> app/views...
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: admin (id=1)
> Rendered users/_mail_notifications.html.erb (12.5ms)
> Rendered users/_preferences.html.erb (412.0ms)
> Rendered users/_form.html.erb (446.3ms)
> Rendered users/_general.html.erb (453.8ms)
> Rendered users/_groups.html.erb (10.5ms)
> Rendered users/_memberships.html.erb (105.9ms)
> Rendered common/_tabs.html.erb (583.8ms)
> Rendered users/edit.html.erb within layouts/admin (599.7ms)
> Missing template, responding with 404
> Rendered common/error.html.erb within layouts/base (0.1ms)
> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1069808

Title:
  Compatibility with 2.1.x

Status in Redmine Local Avatars Plugin:
  New

Bug description:
  Are there any plans on ensuring compatibility with 2.1.x?

  We're using 2.1.3 in the company, and we're trying to make sales
  departments use it along with IT crowd... So the functionality like
  this is highly beneficial to "sell" redmine to sales :)

  current errors:

  Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
  Processing by UsersController#edit as HTML
    Parameters: {"id"=>"30"}
    Current user: admin (id=1)
    Rendered users/_mail_notifications.html.erb (12.5ms)
    Rendered users/_preferences.html.erb (412.0ms)
    Rendered users/_form.html.erb (446.3ms)
    Rendered users/_general.html.erb (453.8ms)
    Rendered users/_groups.html.erb (10.5ms)
    Rendered users/_memberships.html.erb (105.9ms)
    Rendered common/_tabs.html.erb (583.8ms)
    Rendered users/edit.html.erb within layouts/admin (599.7ms)
  Missing template, responding with 404
    Rendered common/error.html.erb within layouts/base (0.1ms)
  Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)

To manage notifications about this bug go to:
https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions