Comment 19 for bug 1069808

Revision history for this message
Oleg V. Kozlyuk (elquentaro) wrote : Re: [Bug 1069808] Re: Compatibility with 2.1.x

Negative... I've asked Andre to send me his whole plugin folder, as
his patch wasn't properly renaming and/or changins some files.

2013/1/18 Luca Pireddu <email address hidden>:
> Did you rename the files with "bzr mv"?
>
> Bzr should take care of communicating any changes through a patch file,
> even file renaming.
>
> Try running
> bzr send -o my.patch
> and then mail me the patch file it generates.
>
> Luca
>
>
> On 18 January 2013 10:11, Oleg V. Kozlyuk <email address hidden> wrote:
>
>> Hi again, guys
>>
>> I've tried to make a patch for the differences between the latest
>> Launchpad version and Andre's version, but there seems to be too much
>> differences like renaming .html.erb into .erb.html.
>> The diff utility doesn't handle it well - it shows such changes as one
>> file being deleted, and the other created.
>>
>> Luca, is it possible to replace the directory altogether and make a
>> commit? I guess, that'd be the easiest way.
>>
>> --
>> You received this bug notification because you are subscribed to Redmine
>> Local Avatars Plugin.
>> https://bugs.launchpad.net/bugs/1069808
>>
>> Title:
>> Compatibility with 2.1.x
>>
>> Status in Redmine Local Avatars Plugin:
>> New
>>
>> Bug description:
>> Are there any plans on ensuring compatibility with 2.1.x?
>>
>> We're using 2.1.3 in the company, and we're trying to make sales
>> departments use it along with IT crowd... So the functionality like
>> this is highly beneficial to "sell" redmine to sales :)
>>
>> current errors:
>>
>> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05
>> +0400 2012
>> Processing by UsersController#edit as HTML
>> Parameters: {"id"=>"30"}
>> Current user: admin (id=1)
>> Rendered users/_mail_notifications.html.erb (12.5ms)
>> Rendered users/_preferences.html.erb (412.0ms)
>> Rendered users/_form.html.erb (446.3ms)
>> Rendered users/_general.html.erb (453.8ms)
>> Rendered users/_groups.html.erb (10.5ms)
>> Rendered users/_memberships.html.erb (105.9ms)
>> Rendered common/_tabs.html.erb (583.8ms)
>> Rendered users/edit.html.erb within layouts/admin (599.7ms)
>> Missing template, responding with 404
>> Rendered common/error.html.erb within layouts/base (0.1ms)
>> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>>
>> To manage notifications about this bug go to:
>> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions
>>
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1069808
>
> Title:
> Compatibility with 2.1.x
>
> Status in Redmine Local Avatars Plugin:
> New
>
> Bug description:
> Are there any plans on ensuring compatibility with 2.1.x?
>
> We're using 2.1.3 in the company, and we're trying to make sales
> departments use it along with IT crowd... So the functionality like
> this is highly beneficial to "sell" redmine to sales :)
>
> current errors:
>
> Started GET "/users/30/edit" for 192.168.44.1 at Пнд Окт 22 17:23:05 +0400 2012
> Processing by UsersController#edit as HTML
> Parameters: {"id"=>"30"}
> Current user: admin (id=1)
> Rendered users/_mail_notifications.html.erb (12.5ms)
> Rendered users/_preferences.html.erb (412.0ms)
> Rendered users/_form.html.erb (446.3ms)
> Rendered users/_general.html.erb (453.8ms)
> Rendered users/_groups.html.erb (10.5ms)
> Rendered users/_memberships.html.erb (105.9ms)
> Rendered common/_tabs.html.erb (583.8ms)
> Rendered users/edit.html.erb within layouts/admin (599.7ms)
> Missing template, responding with 404
> Rendered common/error.html.erb within layouts/base (0.1ms)
> Completed 404 Not Found in 646ms (Views: 13.6ms | ActiveRecord: 8.3ms)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/redminelocalavatars/+bug/1069808/+subscriptions