Some of the strings in Add-in Manager are not translatable

Bug #992420 reported by grofaty
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Pinta
Fix Committed
Medium
Cameron White

Bug Description

Pinta 1.3 on Windows XP.
1. Edit | Add-in Manager
2. Installed tab.
3. Now strings inside window "Core", "Default Effects", "Default Tools" and discriptions for this two elements are not translatable.

Tags: addins
Revision history for this message
grofaty (grofaty) wrote :
Revision history for this message
grofaty (grofaty) wrote :

I have found one more non-translated button. See attachment: Disable button and when clicked Enable button. This strings should also be translatable.

Revision history for this message
Cameron White (cameronwhite91) wrote :

These are really two separate issues - the disable/enable buttons are part of the Mono.Addins.Gui library, and should have been fixed by bug #886501

The other missing translations are from the extensions themselves.

tags: added: addins
Changed in pinta:
importance: Undecided → Medium
milestone: none → 1.5
status: New → Confirmed
Revision history for this message
grofaty (grofaty) wrote :

At #3, I have checked the problem at #2 and it looks like there is no fix for Disable button. English word still appears. See attached print-screen: In background there is Translations from Launchpad and I can see there is "Disable" string in Translations, but translation is not reflected in Pinta application.

Revision history for this message
grofaty (grofaty) wrote :
Revision history for this message
grofaty (grofaty) wrote :

Ahh, the second part of #3: "The other missing translations are from the extensions themselves." --> This problem still exists.

Revision history for this message
Cameron White (cameronwhite91) wrote :

The problem with the Disable button text is an upstream issue with the Mono.Addins library - I've submitted a pull request with a fix (https://github.com/mono/mono-addins/pull/5) so that will eventually be fixed.

Revision history for this message
Cameron White (cameronwhite91) wrote :

My pull request was accepted, so this will be fixed in the next Mono.Addins release. I'm removing this from the 1.5 milestone since there likely won't be a new release of Mono.Addins before then.

Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
milestone: 1.5 → none
status: Confirmed → In Progress
Revision history for this message
Patrick Dreier (patrick-dreier) wrote :

Hello!

pinta-1.5-preview-20130615.exe

With king regards!

Changed in pinta:
assignee: Cameron White (cameronwhite91) → Patrick Dreier (patrick-dreier)
Revision history for this message
Cameron White (cameronwhite91) wrote :

Patrick - DO NOT assign bugs to yourself if you are not a developer!!

Changed in pinta:
assignee: Patrick Dreier (patrick-dreier) → Cameron White (cameronwhite91)
Changed in pinta:
milestone: none → 2.2
Revision history for this message
Cameron White (cameronwhite91) wrote :

This is fixed for Pinta 2.2 since the add-in dialogs are now part of the Pinta repository and included in our translations

Changed in pinta:
status: In Progress → Fix Committed
Revision history for this message
Cameron White (cameronwhite91) wrote :

Re-opening this, since we still should look into making add-ins translateable.
It might be possible to register add-ins under the main Weblate project for Pinta (https://hosted.weblate.org/projects/pinta/), and then figure out how to bundle the translations easily with the add-in

Changed in pinta:
status: Fix Committed → Triaged
Revision history for this message
Cameron White (cameronwhite91) wrote :

I've made some progress on improving translations for add-ins, starting with the night vision effect as a test:
https://github.com/PintaProject/NightVisionEffect/commit/a555c65ae35908a8206c33deeea539abad3d2d0b

And it can be translated on Pinta's Weblate instance now: https://hosted.weblate.org/projects/pinta/nightvisioneffect/

The main blocker I've hit is that the addin metadata (the label "Night Vision Effect", and the description "A simple add-in that will ...") can't be localized in the normal way, and instead need translations to be embedded in the add-in manifest (which weblate doesn't understand). It might require an extra build step to generate a new manifest with all the strings bundled together

Revision history for this message
grofaty (grofaty) wrote :

I see Night Vision Effect strings in Weblate now. Thanks.

But we probably have bigger problem now, Night Vision Effect does not work in Pinta 2.2-dev and even worse when installed it makes Pinta unusable. I have reported separate bug 2047274, to follow one problem per bug report rule.

Revision history for this message
Cameron White (cameronwhite91) wrote :

The night vision effect is now fully translatable with https://github.com/PintaProject/Pinta/commit/31e8709165450ea441134d12242c3402d9e22587 and https://github.com/PintaProject/NightVisionEffect/commit/bc9de591c754b8684e269a69ce6b631fa2f7b16a.

I'll apply similar changes to the other two addins that we maintain (Block Brush and the demo extension)
I've also hidden the default tools and effects extensions since those aren't really useful to users since they can't be uninstalled, and disabling them isn't really supported

Revision history for this message
Cameron White (cameronwhite91) wrote :

The other two add-ins now support translations

Changed in pinta:
status: Triaged → Fix Committed
Revision history for this message
grofaty (grofaty) wrote :

I can confirm I can see translations and I have already translate them.

I hope I translated correctly, I am not familiar with those add-ins and I can't test them at this stage of development. For example I started translating "Block" and I translated it like a verb "to block/prevent something", then from second string "Block Brush" it looks "block" is "something grouped". If you have time, some translations tips would be nice, like one sentence for each of the string.

Also explanation in add-in: "A brush similar to the block brush in GIMP" isn't really helpful, because it requires from the user, to use Gimp. This is explanation by association. Like saying, buffalo is similar to the gnu. It requires someone to know what kind of animal is gnu. May I suggest to change one line description to something else.

Revision history for this message
Cameron White (cameronwhite91) wrote :

I've updated the strings in https://github.com/PintaProject/BlockBrush/commit/ca6529aa9f5e4fe23dc5f30c916b15457bb1fee1 and added comments for translators

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.