code review merge status and docs need clarity, particularly for 'tweak' cases
Bug #373078 reported by
Martin Pool
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
followon from bug 316253
It's pretty common to say "please fix X and Y then merge this".
It's useful to distinguish this from branches that can be merged with no other work.
I guess "needs fixes" may cover this but it's unclear if that means "fix and resubmit" or "fix and merge".
Bundle buggy has "tweak" which is clear and pithy. Being pithy is good because people have to type the status in mail commands and in general conversation about the patch.
Changed in launchpad-code: | |
status: | Incomplete → New |
Changed in launchpad: | |
status: | Incomplete → Triaged |
importance: | Undecided → High |
summary: |
- no code review status for 'merge with some tweaks' + code review merge status and docs need clarity, particularly for 'tweak' + cases |
Changed in launchpad: | |
assignee: | Tim Penhey (thumper) → nobody |
To post a comment you must log in.
We talked about this, but what you are saying is
"This is approved but I'd like you to fix X"
This means "approved" and I trust you. If I don't trust you it is "needs
fixing".