No status for "basically ok, some questions"
Bug #316253 reported by
Jonathan Lange
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Tim Penhey |
Bug Description
When doing code reviews, I often come across basically ok patches with some questions I don't understand. When I'm doing a review through the web, the review form insists I choose a review response type:
* 'Approve' is inappropriate, since I can't approve of it until I understand it.
* 'Needs Fixing' doesn't really match either, since the patch might well be fine.
* 'Abstain' is wrong, since I am going to vote, just not yet.
* 'Disapprove' is definitely out, since it looks basically good.
* 'Resubmit' isn't very clear. I don't necessarily want a new patch, just some answers.
Changed in launchpad-bazaar: | |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in launchpad-code: | |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 2.2.5 |
status: | Triaged → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I've felt that way a few times as well. I end up just commenting, but I agree that a status that says "I looked at it, but please tell me more" would feel better.
"Needs Info"?