Comment 8 for bug 373078

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/6/24 Aaron Bentley <email address hidden>:
>> Needs fixing is meant to mean "This is approved but I'd like you to fix X"
>> Resubmit is meant to be used when the reviewer is withholding approval until changes are made.
>
> OK, so that does seem to cover the options. At least to me, "needs
> fixing" doesn't very obviously imply they have permission to merge
> after fixing it, but maybe I'm mentally biased by BB and previous
> projects.

I'll give you one guess what *I* suggested we call "needs fixing" :-)

> Maybe this could be explained more in
> <https://help.launchpad.net/Code/Review> and then that page could be
> linked from the form?

Couldn't hurt.

Code Review in Launchpad is currently in flux, because its model is
different from BB. In BB, you propose changes to be merged. In Code
Review, you propose a branch to be merged. Because branches, not
specific changes, are proposed for merging, it's not clear whether or
not "resubmit" will become a common action. If it doesn't, then
"resubmit" is a poor label for "Make these changes and I'll have another
look".

As a result, the Launchpad team itself is using "needs fixing" to mean
"Make these changes and I'll have another look".

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpBrXMACgkQ0F+nu1YWqI3nkACfUKjjRIv1kvfjVHA+K9v21UFh
v8wAn2bvwDbuqwmo9D/gTChvwDp0GVe8
=NSww
-----END PGP SIGNATURE-----