Launchpad itself

  1. Bug #373078
  2. Comment #7

Comment 7 for bug 373078

Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 373078] Re: no code review status for 'merge with some tweaks'

2009/6/24 Aaron Bentley <email address hidden>:
> Needs fixing is meant to mean "This is approved but I'd like you to fix X"
> Resubmit is meant to be used when the reviewer is withholding approval until changes are made.

OK, so that does seem to cover the options. At least to me, "needs
fixing" doesn't very obviously imply they have permission to merge
after fixing it, but maybe I'm mentally biased by BB and previous
projects.

Maybe this could be explained more in
<https://help.launchpad.net/Code/Review> and then that page could be
linked from the form?

--
Martin <http://launchpad.net/~mbp/>