"exported area is the drawing" and "exported area is the page" aren't alternative in export

Bug #499965 reported by Pietro Battiston
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
John Smith

Bug Description

1) start Inkscape (0.47, for instance)
2) Click "File" -> "Save a Copy"
3) Select "Encapsulated PostScript (*.eps)"
4) Click "Save"

What happens:
in the next dialog, "exported area is the drawing" and "exported area is the page" are both CheckBoxes

What should happens:
since one behaviour excludes the other, they should be RadioButtons

The same happens with pdf, dxf and presumably other formats.

su_v (suv-lp)
tags: added: eps exporting pdf ui
Revision history for this message
Alvin Penner (apenner) wrote :

confirmed, for the 4 possible states of the checkboxes, there are only two outcomes.
- "drawing" box checked, and both boxes checked, both lead to the same outcome.
- "page" box checked, and neither box checked, both lead to the same outcome
- therefore radio buttons would be more appropriate

Changed in inkscape:
status: New → Confirmed
Revision history for this message
Casey Peel (cpeel) wrote :

I noticed this as well (prior to finding this bug) and went off to fix it. The initial wording of the two checkboxes along with the pairing of the "Limit export to the object with the ID" option confused the heck out of me as to what they actually did as initially I thought they controlled what was being output. Instead they control the output's bounding box. Fixing this is fairly easy and I have a patch that does so but I think we need more than a straightforward conversion to radio boxes -- we need new wording for them too.

My current thought is something along the lines of:

Output page size:
o Retain document's page size
o Shrink page size to exported objects

Thoughts?

I see that this would need to be changed for PDF and EPS. I wasn't able to find that option for DXF or other format but if you can point me to them I'll look at those too.

Revision history for this message
stehpan (stehpan) wrote :

In Inkscape 0.48.2 r9819 (on Linux Ubuntu 11.10) there are still check boxes for that. (I tested EPS and PS export.)
Radio buttons would be clearer.

I find the new wording quite nice. (Not sure what the current Englisch wording is.)
The current German translation reads pretty ambiguous:
"Exportierter Bereich ist die gesamte Zeichnung"
"Exportierter Bereich ist die gesamte Seite"
(I never know which of the two resulting BoundingBoxes will be smaller.)

On the other hand, for eps currently it does not matter which checkbox is checked, see bug #380501. It will always export "drawing".
If there are radio buttons/check boxes they should work.

Revision history for this message
John Smith (john-smithi) wrote :

Patch to convert the checkboxes into radio buttons.
Logic of those selections should be unchanged.

Modified to the wording slightly, to keep the grammar consistent :

Output page size
* Use documents page size
* Shrink to exported objects size

Changed in inkscape:
assignee: nobody → John Smith (john-smithi)
status: Confirmed → In Progress
Revision history for this message
stehpan (stehpan) wrote :

Thanks for this patch!

I'm not an English native speaker, nor a programmer, but I think it should be:

Output page size
* Use document's page size
* Shrink to exported object's size

We don't export multiple documents/objects(=no plural s), but the (page) size is "owned" by the original document/exported object (=possessive case).

On the other hand I'm not sure how to escape an apostrophe in a patch file. Would \' be correct?
"<option value=\"page\">" N_("Use document\'s page size") "</option>"

Revision history for this message
su_v (suv-lp) wrote :

> * Shrink to exported objects size

The drawing content can also be larger than the page size (in this case, the exported area expands…)

Revision history for this message
John Smith (john-smithi) wrote :

Thanks for the comments, wording amended to :

Output page size
* Use document's page size
* Use exported object's size

(Apostrophe can be added as-is inside a double-quoted string).

jazzynico (jazzynico)
Changed in inkscape:
importance: Undecided → Low
Revision history for this message
jazzynico (jazzynico) wrote :

Tested on Windows XP, Inkscape revision 11649.

Attached is a slightly modified patch that applies the changes to the PDF export dialog, removes the comments and fixes some tabs/spaces formating issues.

Revision history for this message
jazzynico (jazzynico) wrote :
Revision history for this message
John Smith (john-smithi) wrote :

v3 patch committed to trunk as r11654

Thanks stephan, ~suv for your input, and JazzyNico for the improved patch !

Changed in inkscape:
status: In Progress → Fix Committed
Kris (kris-degussem)
Changed in inkscape:
milestone: none → 0.49
Revision history for this message
su_v (suv-lp) wrote :

Late comment about the changes in r11654:

To me the current wording in trunk is confusing (caveat: English is not my native language - possibly I miss a grammatical subtlety in the use of the apostrophe (?)):

---
 [x] Use document's page size
 [ ] Use exported object's size
 Limit export to object with ID: [ ___ ]
---

One could easily read this as if "Use exported object's size" only works in combination with "Limit export to object with ID" because both use the singular form "object". The settings however are not connected:
- a single object can be exported either with page size or the object's size,
- with no ID specified, the option "Use exported object's size" (formerly called "Export area is drawing") refers to all objects (plural) in drawing (including those outside the page).

The term 'Drawing' is used elsewhere in Inkscape to describe the same area (e.g. Export Bitmap, Document Properties > Page) - it's not really clear to me why it ought to be changed for PS/EPS and PDF export into referring to a _single_ object.

Revision history for this message
su_v (suv-lp) wrote :

The changes in r11654 possibly introduced a regression when exporting to pdf via command line interface:
Bug #1059132 “--export-pdf crashes with inkscape trunk "
<https://bugs.launchpad.net/inkscape/+bug/1059132>

Revision history for this message
stehpan (stehpan) wrote :

Bug #1059132 has been set to "Fix Released", so the regression should be gone.

Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.