Issues Placing Holds from the Patron Record, Angular and AngularJS
Bug #1996818 reported by
Michele Morgan
This bug affects 11 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
High
|
Unassigned | ||
3.10 |
Fix Released
|
High
|
Unassigned |
Bug Description
Evergreen 3.10
The following commit from the Angular Patron Interfaces port (bug 1904036):
https:/
introduced a few issues related to placing holds from the Patron Record Holds screens.
- AngularJS Patron Holds - Place Holds button doesn't load patron information - see bug 1995770
- Angular Patron Holds - Place Holds button causes patron info to persist in angular catalog - see comments on bug 1949226
Setting Importance to High as these issues will disrupt the staff Place Holds workflow in both the AngularJS and Angular screens.
Changed in evergreen: | |
status: | New → Confirmed |
Changed in evergreen: | |
assignee: | nobody → Dan Briem (dbriem) |
Changed in evergreen: | |
assignee: | nobody → Jason Stephenson (jstephenson) |
Changed in evergreen: | |
status: | Confirmed → In Progress |
Changed in evergreen: | |
milestone: | 3.10.1 → 3.10.2 |
Changed in evergreen: | |
assignee: | Jason Stephenson (jstephenson) → nobody |
status: | In Progress → Confirmed |
Changed in evergreen: | |
milestone: | 3.10.2 → 3.10.3 |
Changed in evergreen: | |
assignee: | nobody → Dan Briem (dbriem) |
Changed in evergreen: | |
assignee: | Dan Briem (dbriem) → nobody |
Changed in evergreen: | |
milestone: | none → 3.12-beta |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Branch for testing: https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dbriem/ lp1996818_ holds_from_ patron_ record
This clears the patron hold target cookie when navigating from the staff/catalog route, when the window is closed, and when holds are successfully placed.
This also changes the AngularJS patron interface to set the same session cookie as the Angular interface.
The comments on bug 1949226 mentioned "same search" as the ideal persistence, but that may be too restrictive if staff need multiple searches to find an item or if they want to place multiple holds using the bucket interface. I think successfully placing a hold might be a better proxy for a "session" and might be more consistent given, when not initiating a hold from the patron interface and instead searching for a patron in the catalog, that patron's data is cleared after holds are successfully placed.