We have had some time to review Dan's updated branch at CW MARS yesterday and today. It works on 3.10.2 as well as master thanks to Dan's latest updates.
I've pushed a signoff branch with both John Amundson's and my signoff added to
I'm not pushing this to the main repsository right now in case anyone wants to discuss the approach taken as mentioned by Dan in comment #11. I have no issues with it.
The code could also stadnd more scrutiny. Just because it works for CW MARS doesn't mean it necessarily works for eveyone.
We have had some time to review Dan's updated branch at CW MARS yesterday and today. It works on 3.10.2 as well as master thanks to Dan's latest updates.
I've pushed a signoff branch with both John Amundson's and my signoff added to
user/dyrcona/ lp1996818_ broadcast_ patron_ hold_target- signoff (https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ dyrcona/ lp1996818_ broadcast_ patron_ hold_target-
signoff)
I'm not pushing this to the main repsository right now in case anyone wants to discuss the approach taken as mentioned by Dan in comment #11. I have no issues with it.
The code could also stadnd more scrutiny. Just because it works for CW MARS doesn't mean it necessarily works for eveyone.