Time is my enemy and git amend is not cooperating for --signoff so since no
one actually signed off in git to the previous branch just via launchpad ...
On Thu, Aug 20, 2020 at 12:15 PM Jane Sandberg <email address hidden>
wrote:
> Thanks for the patch, Rogan, and for the testing, Beth. It works well
> for me also.
>
> I'll be happy to merge this, but it's missing a few things:
> * Rogan's signoff is missing from the original commit
> * Commit message should start with the bug number
> * Upgrade script should be wrapped in a transaction, with the
> evergreen.upgrade_deps_block_check line included
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> https://bugs.launchpad.net/bugs/1771386
>
> Title:
> bib record merges should mark bib inactive
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.1 series:
> Won't Fix
> Status in Evergreen 3.2 series:
> Won't Fix
> Status in Evergreen 3.3 series:
> Won't Fix
> Status in Evergreen 3.4 series:
> Confirmed
>
> Bug description:
> When the biblio record entry delete command is issued the bib is both
> flagged as deleted and inactive. The asset.merge_record_assets
> function is only marking it deleted but not inactive. Both should be
> done for consistency.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1771386/+subscriptions
>
Time is my enemy and git amend is not cooperating for --signoff so since no
one actually signed off in git to the previous branch just via launchpad ...
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=commit; h=465b55bfb71ec 70675d8e969d113 4c726aeccdee
On Thu, Aug 20, 2020 at 12:15 PM Jane Sandberg <email address hidden>
wrote:
> Thanks for the patch, Rogan, and for the testing, Beth. It works well upgrade_ deps_block_ check line included /bugs.launchpad .net/bugs/ 1771386 record_ assets /bugs.launchpad .net/evergreen/ +bug/1771386/ +subscriptions
> for me also.
>
> I'll be happy to merge this, but it's missing a few things:
> * Rogan's signoff is missing from the original commit
> * Commit message should start with the bug number
> * Upgrade script should be wrapped in a transaction, with the
> evergreen.
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> https:/
>
> Title:
> bib record merges should mark bib inactive
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.1 series:
> Won't Fix
> Status in Evergreen 3.2 series:
> Won't Fix
> Status in Evergreen 3.3 series:
> Won't Fix
> Status in Evergreen 3.4 series:
> Confirmed
>
> Bug description:
> When the biblio record entry delete command is issued the bib is both
> flagged as deleted and inactive. The asset.merge_
> function is only marking it deleted but not inactive. Both should be
> done for consistency.
>
> To manage notifications about this bug go to:
> https:/
>