bib record merges should mark bib inactive

[Rogan Hamby]

When the biblio record entry delete command is issued the bib is both flagged as deleted and inactive. The asset.merge_record_assets function is only marking it deleted but not inactive. Both should be done for consistency.

[Garry Collum (gcollum)]

While confirming this bug I found a related issue that may require a separate LP entry.

If you undelete a bib in the xul client, active is set to true, deleted is set to false. If you undelete a bib in the web client, active remains false, deleted is set to false.

[Rogan Hamby (rogan-hamby)]

Branch for this issue at user/rogan/lp1771386_merged_bib_should_be_inactive, 7df1f00a2466324feee56cf0ca89a4d82023dcbf

Garry, did you file a launchpad bug for the webclient undelete behavior?

[Michele Morgan (mmorgan)]

Adding a link to the working branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rogan/lp1771386_merged_bib_should_be_inactive

Also setting targets.

[Beth Willis (willis-a)]

 I have tested this code and consent to signing off on it with my name, Beth Willis and my email address, <email address hidden>

[Jane Sandberg (sandbergja)]

Thanks for the patch, Rogan, and for the testing, Beth. It works well for me also.

I'll be happy to merge this, but it's missing a few things:
* Rogan's signoff is missing from the original commit
* Commit message should start with the bug number
* Upgrade script should be wrapped in a transaction, with the evergreen.upgrade_deps_block_check line included

[Rogan Hamby (rogan-hamby)]

Time is my enemy and git amend is not cooperating for --signoff so since no
one actually signed off in git to the previous branch just via launchpad ...

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=465b55bfb71ec70675d8e969d1134c726aeccdee

On Thu, Aug 20, 2020 at 12:15 PM Jane Sandberg <email address hidden>
wrote:

> Thanks for the patch, Rogan, and for the testing, Beth. It works well
> for me also.
>
> I'll be happy to merge this, but it's missing a few things:
> * Rogan's signoff is missing from the original commit
> * Commit message should start with the bug number
> * Upgrade script should be wrapped in a transaction, with the
> evergreen.upgrade_deps_block_check line included
>
> --
> You received this bug notification because you are a member of Evergreen
> Bug Wranglers, which is subscribed to Evergreen.
> https://bugs.launchpad.net/bugs/1771386
>
> Title:
> bib record merges should mark bib inactive
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.1 series:
> Won't Fix
> Status in Evergreen 3.2 series:
> Won't Fix
> Status in Evergreen 3.3 series:
> Won't Fix
> Status in Evergreen 3.4 series:
> Confirmed
>
> Bug description:
> When the biblio record entry delete command is issued the bib is both
> flagged as deleted and inactive. The asset.merge_record_assets
> function is only marking it deleted but not inactive. Both should be
> done for consistency.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1771386/+subscriptions
>

[Jane Sandberg (sandbergja)]

Forgot to comment that I had merged this to rel_3_4, rel_3_5, and master. Thanks, Rogan and Beth.