Comment 6 for bug 1491875

Revision history for this message
Andrea Neiman (aneiman) wrote :

Tested this in the following situations:

- created new bib record using the method described above: OK -- no warning, record created as expected
- edited bib record using method described in bug 1282277 : OK -- only got warning when expected
- created auth record (both "create immediately" and "create and edit"): OK -- only got warning when expected
- ran all 6 of Yamil's tests here https://bugs.launchpad.net/evergreen/+bug/1282286/comments/21 and all got results that I would consider normal/expected (note that test #4 on that list I think is expected behavior -- you get the warning when switching from MARC Editor to another view, but not when you close from another View *IF* you clicked "OK" on the warning. If you click "cancel" on the warning, and then try to close the tab, you are prompted again with the warning.)
- edited a record from z39.50 import -- only got warning when expected
- edited a record from Vandelay import -- only got warning when expected
- created a MFHD record -- only got warning when expected

Note that there are two cases where an existing tab-lock issue still shows up, but they were not introduced/worsened by this fix:
- edited a MFHD record -- got erroneous warning when closing the popup despite having clicked save
- edited an auth record -- after the popup is saved & auto-closes, navigating away from or closing the authority tab will generate an erroneous warning.

I have tested this code and consent to signing off on it with my name, Andrea Neiman and my email address, <email address hidden>