MARC edit no save data warning when leaving a record

[Liam Whalen]

When editing a MARC record, if users make edits then change to new screens, such as the OPAC view, they will be given a warning that they might lose data.

If they click OK on that warning then they are taken to the new screen. If they then return to the MARC editor, their changes will still be present, but if they change to a different screen a second time they will not be given a lose data warning message.

Evergreen 2.4.0
OpenSRF 2.2.0
PostgreSQL 9.1
Ubuntu 12.04

In the staff client

Search -> Search the Catalog
enter a search term and submit the search
click on a record in the search results
Actions for this Record -> MARC Edit
edit a field and add or remove multiple characters
Actions for this Record -> OPAC View
click ok on the warning that appears
Actions for this Record -> MARC Edit
verify that your changes are still present
Actions for this Record -> OPAC View

no warning is presented, the user is take directly to the OPAC view

The users should be prompted again that they will lose data

[Liam Whalen (whalen-ld)]

I have a fix for this, and I am going to integrate it into master. Hopefully, it can be added to the rc1 release.

[Liam Whalen (whalen-ld)]

This fix works in concert with https://bugs.launchpad.net/evergreen/+bug/1282286

[Liam Whalen (whalen-ld)]

I have merged my changes into master. They can be found here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ldw/LP1282277_LP1282286_MARC_EDIT_SAVE_AND_TCN_SEARCH

[Kyle Tomita (tomitakyle)]

Reviewing this card with https://bugs.launchpad.net/evergreen/+bug/1282286 since the commit is together. Please see that card for status of testing.

[Kyle Tomita (tomitakyle)]

Signedoff on this one with LP1282286 on this branch, http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ktomita/lp1282277_lp1282286-signoff

[Liam Whalen (whalen-ld)]

There is an bug in this code that cause duplicate records to be created when performing Cataloguing -> Create New MARC Record. It also creates a UI bug when importing via Cataloguing -> Import Record from Z39.50.

I am working on fixing this.

[Liam Whalen (whalen-ld)]

The updates for this fix can be found here:

https://bugs.launchpad.net/evergreen/+bug/1282286

[Liam Whalen (whalen-ld)]

There are even more bugs. This fix should stop all bugs of this sort:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ldw/Unintialized_Vars_Fix

[Kathy Lussier (klussier)]

Marking this one as a duplicate of https://bugs.launchpad.net/evergreen/+bug/1282286 since all of the code is meged on to the branch posted there. Thanks Liam!