Request acquisitions to make the year select box to default to the fiscal year instead of the current year.

Bug #1026276 reported by Steve Callender on 2012-07-18
46
This bug affects 10 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

In 2.2+, when going into acquisitions > funds using the template screens, the year defaults to the current year rather than the fiscal year. It would be much more convenient if the year defaulted to the fiscal year somehow instead, since the fiscal year might already be the next year.

The code in question is the loadYearSelector function in,

/openils/var/web/js/ui/default/acq/financial/list_funds.js

Steve

Tags: acq Edit Tag help
Changed in evergreen:
status: New → Triaged
tags: added: acq
Kathy Lussier (klussier) on 2013-07-10
Changed in evergreen:
status: Triaged → Confirmed

This is still an issue in 2.9.1.

Jason Stephenson (jstephenson) wrote :

The logic in that function is far too simple to handle fiscal years.

First, it grabs the list of years from the acq.fund table, and not from acq.fiscal_year. It does this using the open-ils.acq.fund.org.years.retrieve method.

Second, it sets the default to the year that matches the current calendar year.

To make it aware of fiscal years, it would need to retrieve the dates from acq.fiscal_year. This also means that it would likely need to be made aware of different acq.fiscal_calendar entries and have some way to determine which calendar is in force for the current organizational unit.

It would then need to check the current date against the list of start and end dates for the various fiscal years to determine which fiscal year is current.

I have not looked through all of the acquisitions code surrounding this issue, but I suspect there will need to be some back end changes as well as client JavaScript changes to address the issue as reported.

Kathy Lussier (klussier) wrote :

I think we've had a couple of bugs on this issue that shows the evolution of this feature.

Shortly after Steve filed this bug, Shae filed bug 1031927, which probably should have been filed as a duplicate, but was missed. From reading that bug, my understanding is, at the time, there was no fiscal year selector on the Upload form.

In August 2012, Bill submitted code that provided the fiscal year selector and provided pcrud access to fiscal year / fiscal calendar so that the selector could default to the current fiscal year. That code was merged to 2.3 and backported to 2.2.

Two years later, I filed bug 1348228 saying that the selector was no longer defaulting to the fiscal year in 2.5. It did appear to default to the fiscal year when I worked on a system that only contained funds for that fiscal year, which falls within what Jason was saying in his above comment.

Although using different fiscal years for different org units would be a 'nice to have' feature, I think most of us would be happy with it defaulting to the global fiscal year that can be set in the database. Most consortia I work with find that most if not all of their libraries are on the same fiscal calendar. Getting the dropdown to default to that fiscal year would benefit the most number of libraries without building the new feature.

I'm going to mark bug 1348228 as a duplicate of this one.

Kathy Lussier (klussier) wrote :

Oof. I just realized that these two aren't the same bugs. This one addresses the funds interface and the other addresses the MARC order upload form. Please ignore my last comment. Sorry for the noise.

Changed in evergreen:
importance: Undecided → Medium
Tiffany Little (tslittle) wrote :

Although Kathy ended up having talked about another bug, I agree with her last paragraph even in the context of this bug. Different FYs for different org units would be a nice to have, but just defaulting to the global fiscal year would be plenty fine for us, if that simplifies making this happen.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers