Comment 2 for bug 1026276

Revision history for this message
Jason Stephenson (jstephenson) wrote :

The logic in that function is far too simple to handle fiscal years.

First, it grabs the list of years from the acq.fund table, and not from acq.fiscal_year. It does this using the open-ils.acq.fund.org.years.retrieve method.

Second, it sets the default to the year that matches the current calendar year.

To make it aware of fiscal years, it would need to retrieve the dates from acq.fiscal_year. This also means that it would likely need to be made aware of different acq.fiscal_calendar entries and have some way to determine which calendar is in force for the current organizational unit.

It would then need to check the current date against the list of start and end dates for the various fiscal years to determine which fiscal year is current.

I have not looked through all of the acquisitions code surrounding this issue, but I suspect there will need to be some back end changes as well as client JavaScript changes to address the issue as reported.