update-grub hardcodes to 'Ubuntu'

[Brian Brazil]

Binary package hint: grub

From update-grub(dapper):

# Title
title="Ubuntu"

For downstream distributions this requires rebuilding the grub package, which should not be nessecary.
Please change this to:

title=`/bin/lsb_release -si`

Don't forget to add a Depends on lsb-release

[Mantas Kriaučiūnas (mantas)]

I'm suggesting to use --description option instead of -i (distribution id), description is more user-friendly than ID, also from description user will know which version of distribution he is running. Also lsb_release command is in /usr/bin (at least in Ubuntu 7.04 „Feisty“). So, title variable in update-grub script should be:

title=`/usr/bin/lsb_release -s --description`

[Tormod Volden (tormodvolden)]

Oh, I didn't see your comment about "distribution", but I can make a new patch. I am not sure how urgent this is. I'd suggest you file a bug in Debian, if they don't react, we'll include this in the next Ubuntu version.

[Tormod Volden (tormodvolden)]

hey why wait :) It might be nice to have this in soon, for those distributions that will be based off Gutsy. I chose to use --description, it looks a little long and awkward while Gutsy is in development, but it will look nice once it is released.

[Tormod Volden (tormodvolden)]

For your convenience, I attached a debdiff to bug #131858 which also includes the patch in this bug.

[Tormod Volden (tormodvolden)]

grub (0.97-29ubuntu4) gutsy; urgency=low

  * debian/update-grub: replace Ubuntu with lsb_release if possible
    (LP: #83690, #19040)
  * debian/update-grub: on upgrades, set the new savedefault option
    to "true" if the user was using "default saved" (LP: #131858)

 -- Tormod Volden <email address hidden> Mon, 03 Sep 2007 22:56:34 +0200

[Tormod Volden (tormodvolden)]

I made a fallback to "Ubuntu" if lsb-release failed/was not found. Now that I think of it, the fallback should have been "GNU/Linux" for distribution neutrality. That would have made rms happy! I'll think about that next time.