Branch:+register-merge / Specification:+linkbranch time out due to substring matching many tables
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Steve Kowalik |
Bug Description
got this attempting to propose a merge of one of my branches to pitti using the full url to the branch. Tried a couple more times but still got oopses.
Worked correctly when I specified the branch using its short name, "lp:~pitti/postgresql/debian-9.0".
OOPS-1984A11
See also bug 496041 which asks for less hits on substring matches (or better locality/weighting)
The culprit query includes this component:
(SELECT Branch.id
which -hot- has 1 second of table scanning overhead (0.3 in the branch.name check, 0.6 in the person.name check) but may be substantially more given that there are 300K branches and 1.2M person rows.
Related branches
- William Grant (community): Approve (code)
-
Diff: 901 lines (+133/-386)11 files modifiedlib/lp/code/feed/branch.py (+5/-8)
lib/lp/code/interfaces/branchcollection.py (+6/-12)
lib/lp/code/model/branch.py (+4/-0)
lib/lp/code/model/branchcollection.py (+39/-87)
lib/lp/code/model/tests/test_branchcollection.py (+26/-96)
lib/lp/code/stories/feeds/xx-branch-atom.txt (+5/-4)
lib/lp/code/vocabularies/branch.py (+10/-35)
lib/lp/code/vocabularies/tests/branch.txt (+0/-13)
lib/lp/code/vocabularies/tests/test_branch_vocabularies.py (+36/-127)
lib/lp/registry/model/product.py (+0/-2)
lib/lp/services/webapp/configure.zcml (+2/-2)
description: | updated |
tags: | added: oops |
tags: |
added: timeout removed: oops |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Critical |
summary: |
- OOPS-1984A11 proposing branch for merge + Branch:+register-merge time out |
summary: |
- Branch:+register-merge time out + Branch:+register-merge time out due to substring matching many tables |
description: | updated |
tags: | added: critical-analysis |
description: | updated |
summary: |
- Branch:+register-merge time out due to substring matching many tables + Branch:+register-merge / Specification:+linkbranch time out due to + substring matching many tables |
Changed in launchpad: | |
assignee: | nobody → Steve Kowalik (stevenk) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Just bit me in OOPS-2029E2.