Missing +new in Digest email

[Kathy Gee]

In the email that Digest subscribers receive, the first line of instruction provides an email address that is missing the "+new"

Currently it says:

Send [listname] mailing list submissions to:
     [listname]@systers.org.

Should say:

Send [listname] mailing list submissions to:
     [listname]+<email address hidden>

[beachbrake (wordsofagirl)]

This patch fixes the bug. Will have to add Handlers/ToDigest.py. A single line change in that file.

[Yian Shang (yian-shang)]

I've attached a slightly different patch that uses C-style string formatting. It seems more consistent in style with what's used in the MailList class.

[Anne Gunn (ompeag)]

The base mailman code appears to support an extensive number of local languages. But, as far as I can see, all the dlist code is hard-coded to English so that we really do mean we want '+new' in the inbound address for any new dlist email, no matter what the language or charset of the sender.

If so, either fix submitted so far looks as if it will work for the systers-only version of the dlist code.

But if/when we merge into the base mailman distribution, we may be requested/required to support local language (or at least local charset) versions of '+new', in which case a better but substantially larger change would be required to supply both of the parts of the email to the local language template code. But then, of course, there's an equally big task to parse the language-varying +new when we get a message in.

Are the globalization/localization requirements for merging our dlist code with mailman well defined?

[Anne Gunn (ompeag)]

Note also that both of the suggested fixes are changes to a mailman file, not one of the one's we've previously declared to have systers-specific changes. So, at a minimum, fixing this bug requires adopting/checking-in another systers-specific file.

It might be better though, to use this wee fix as a stepping stone to our eventual mailman integration where, presumably, our dlist features will be optional. So rather than unilaterally plug in the +new, we could call a method that would return a 'dlistExtra' string that a) would be blank if the dlist feature is disabled, b) would be '+new' if dlist is enabled, and c) eventually could be localized if we decide to support globalization.

[T E Jagannathan (jagan605)]

Fixed the problem that existed in the patch. Now the digest has the correct email address to reply.

[Sneha Priscilla (stylistica)]

This is a patch for adding +new to digest mail.

Currently, for dlists , the digest mail received says :
Send Systers-dev mailing list submissions to
        <email address hidden>
It should say :

Send Systers-dev mailing list submissions to
        <email address hidden>

The previous patches submitted involved changes to ToDigest.py which is a mailman file and hence, not preferable . In this patch,
I've made changes to MailList.py from where the list address is obtained and made it dlist-specific.

[Garima Ahuja (garimaahujaishere)]

Hi,

The attached patch adds "+new" to the email address in digest mails of dlists while leaving the digest mails of non-dlists as it is.

The changes are made to:
/Mailman/MailList.py

I have tested the changes for dlists and non-dlists, it worked.

[Sneha Bhattacharya (sneha-22-7)]

The bug can be fixed by adding an extra condition in /Mailman/MailList.py.

[Joanna Skrzeszewska (jskrzeszewska)]

I'm not sure if changing getListAddress is OK. This method is used in many places.
I provided another method used only for digest message. I also implemented a simple unit test for it.

[Saumya Gurtu (saumya)]

Hello,

The attached patch adds "+new" to the email address in digest mails of dlists but leaves the digest mails of non-dlists as it is.
The changes are made to: /Mailman/MailList.py
I have tested the changes for dlists and non-dlists, it worked on my laptop :) .