paramiko should be default client for Windows
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Alexander Belchenko | ||
2.0 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
On Windows paramiko should be used as default client, or at least bzr should prohibit to use plink.exe as default client if it found along the $PATH. The reason for this is the problem with initial connection: plink want to ask user about trusting ssh server fingerprint and doing this via usual stdout/stdin and bzr unable to handle this in any reasonable way. So people just can't connect.
Paramiko accept fingerprints implicitly and thus one can say this is possible security hole. But if you choose between 2 options: does not work at all and accept ssh server signature implicitly and work -- I'd say most of windows users will choose the latter.
In the end BZR_SSH=plink will force usage of plink, so who need plink can use it with extra settings.
I saw too much times people has problem to connect to lp branches because of plink problems. And using paramiko instead always solved the problem. So why not?
Related branches
- Vincent Ladeuil: Approve
-
Diff: 31 lines (+4/-4)2 files modifiedbzrlib/lazy_regex.py (+3/-3)
doc/en/release-notes/bzr-2.7.txt (+1/-1)
Changed in bzr: | |
milestone: | none → 2.0 |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
That makes sense to me. It should be an easy change.
It would be nice to separately file a bug about paramiko using the uifactory to confirm the key.
I think there may be a bug for the plink behaviour.