please merge activereviews and approvedmerges
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tim Penhey |
Bug Description
I'm finding that some merges seem to be "missing" from <https:/
I was originally going to just ask that there be a link from activereviews to approvedmerges, but on further consideration I don't think it makes sense for them to be separate at all. In both cases they represent work-in-progress or lean-waste that ought to be finished off; this is equally true whether the work is waiting for review, waiting for resubmission or waiting to merge.
Activereviews currently shows things in all different states separated by headings and this works reasonably well. (Though the precise meaning of the headings is not totally clear.) I think it'd be best to just add one more heading, being approved reviews. Then if it's really wanted, as a separate item we can have some kind of filtering mechanism.
Changed in launchpad-code: | |
assignee: | nobody → Tim Penhey (thumper) |
importance: | Undecided → High |
milestone: | none → 3.0 |
status: | New → In Progress |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
On Mon, 10 Aug 2009 20:08:14 Martin Pool wrote: /code.edge. launchpad. net/bzr/ +activereviews> - the reason being /code.edge. launchpad. net/bzr/ +approvedmerges>.
> Public bug reported:
>
> I'm finding that some merges seem to be "missing" from
> <https:/
> that they are now approved and therefore they have gone to
> <https:/
>
> I was originally going to just ask that there be a link from
> activereviews to approvedmerges, but on further consideration I don't
> think it makes sense for them to be separate at all. In both cases they
> represent work-in-progress or lean-waste that ought to be finished off;
> this is equally true whether the work is waiting for review, waiting for
> resubmission or waiting to merge.
>
> Activereviews currently shows things in all different states separated
> by headings and this works reasonably well. (Though the precise meaning
> of the headings is not totally clear.) I think it'd be best to just add
> one more heading, being approved reviews. Then if it's really wanted,
> as a separate item we can have some kind of filtering mechanism.
I was thinking about this exact think for the personal review page. For a
personal one I'd tend to put the approved merges at the top because they
should really be actioned as soon as possible (approved code that sits
unmerged is a liability).
Do you think that this would fit for projects too?
Tim