please merge activereviews and approvedmerges

[Martin Pool]

I'm finding that some merges seem to be "missing" from <https://code.edge.launchpad.net/bzr/+activereviews> - the reason being that they are now approved and therefore they have gone to <https://code.edge.launchpad.net/bzr/+approvedmerges>.

I was originally going to just ask that there be a link from activereviews to approvedmerges, but on further consideration I don't think it makes sense for them to be separate at all. In both cases they represent work-in-progress or lean-waste that ought to be finished off; this is equally true whether the work is waiting for review, waiting for resubmission or waiting to merge.

Activereviews currently shows things in all different states separated by headings and this works reasonably well. (Though the precise meaning of the headings is not totally clear.) I think it'd be best to just add one more heading, being approved reviews. Then if it's really wanted, as a separate item we can have some kind of filtering mechanism.

[Tim Penhey (thumper)]

On Mon, 10 Aug 2009 20:08:14 Martin Pool wrote:
> Public bug reported:
>
> I'm finding that some merges seem to be "missing" from
> <https://code.edge.launchpad.net/bzr/+activereviews> - the reason being
> that they are now approved and therefore they have gone to
> <https://code.edge.launchpad.net/bzr/+approvedmerges>.
>
> I was originally going to just ask that there be a link from
> activereviews to approvedmerges, but on further consideration I don't
> think it makes sense for them to be separate at all. In both cases they
> represent work-in-progress or lean-waste that ought to be finished off;
> this is equally true whether the work is waiting for review, waiting for
> resubmission or waiting to merge.
>
> Activereviews currently shows things in all different states separated
> by headings and this works reasonably well. (Though the precise meaning
> of the headings is not totally clear.) I think it'd be best to just add
> one more heading, being approved reviews. Then if it's really wanted,
> as a separate item we can have some kind of filtering mechanism.

I was thinking about this exact think for the personal review page. For a
personal one I'd tend to put the approved merges at the top because they
should really be actioned as soon as possible (approved code that sits
unmerged is a liability).

Do you think that this would fit for projects too?

Tim

[Martin Pool (mbp)]

2009/8/10 Tim Penhey <email address hidden>:
> I was thinking about this exact think for the personal review page.  For a
> personal one I'd tend to put the approved merges at the top because they
> should really be actioned as soon as possible (approved code that sits
> unmerged is a liability).
>
> Do you think that this would fit for projects too?

I think that would fit well - if they're the most important thing for
a person they're the most important thing for a team too.

Making them consistent makes it easier to understand how they relate.

For a team there's also the slight complication that there are some
things on which you personally can't take any action.

For the moment combining the pages is the best next step I can think of.

--
Martin <http://launchpad.net/~mbp/>

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tim Penhey wrote:
> I was thinking about this exact think for the personal review page. For a
> personal one I'd tend to put the approved merges at the top because they
> should really be actioned as soon as possible (approved code that sits
> unmerged is a liability).

I would put approved merges proposed by the user at the top everywhere.
 I am not sure I'd want approved merges by others on the active reviews
page at all. If it was there, I'd want it way, way below everything
else, because there's nothing I can do with it.

And we need filtering, so that people can find inactive reviews, too.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqKrwsACgkQ0F+nu1YWqI3TQwCdEedW1c653m2TLQlVng05YmEe
IUAAn0lSx2Rv4Zi9mBjY7rXuXPmJt7SD
=6QQJ
-----END PGP SIGNATURE-----

[Martin Pool (mbp)]

2009/8/18 Aaron Bentley <email address hidden>:
> I would put approved merges proposed by the user at the top everywhere.
>  I am not sure I'd want approved merges by others on the active reviews
> page at all.  If it was there, I'd want it way, way below everything
> else, because there's nothing I can do with it.

You can encourage your team mates to merge them, or you can look into
merging them yourself. So I think they should be shown all the same.
You want to drive that stuff to zero just like you drive your own work
to zero.

I think eventually some level of filtering to show all reviews, only
reviews I'm involved in, and other kinds of filtering may be good.
But I do think it's important that people can always see the big
picture, so I'd aim to get that right first then add filtering.

--
Martin <http://launchpad.net/~mbp/>

[Tim Penhey (thumper)]

On Thu, 20 Aug 2009 19:19:50 Martin Pool wrote:
> 2009/8/18 Aaron Bentley <email address hidden>:
> > I would put approved merges proposed by the user at the top everywhere.
> > I am not sure I'd want approved merges by others on the active reviews
> > page at all. If it was there, I'd want it way, way below everything
> > else, because there's nothing I can do with it.
>
> You can encourage your team mates to merge them, or you can look into
> merging them yourself. So I think they should be shown all the same.
> You want to drive that stuff to zero just like you drive your own work
> to zero.
>
> I think eventually some level of filtering to show all reviews, only
> reviews I'm involved in, and other kinds of filtering may be good.
> But I do think it's important that people can always see the big
> picture, so I'd aim to get that right first then add filtering.
>
> --
> Martin <http://launchpad.net/~mbp/>

I guess there is also going to be
https://code.launchpad.net/people/+me/+activereviews
which will only show your own reviews, those approved and ready to land, those
reviews you have been requested to do, those you are doing, and those you are
waiting on.

Tim

[Michael Hudson-Doyle (mwhudson)]

Tim Penhey wrote:

> I guess there is also going to be
> https://code.launchpad.net/people/+me/+activereviews
> which will only show your own reviews, those approved and ready to land, those
> reviews you have been requested to do, those you are doing, and those you are
> waiting on.

http://code.launchpad.net/~mwhudson/launchpad/+activereviews would also
be nice :)

Cheers,
mwh