Comment 5 for bug 411300

Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 411300] [NEW] please merge activereviews and approvedmerges

On Thu, 20 Aug 2009 19:19:50 Martin Pool wrote:
> 2009/8/18 Aaron Bentley <email address hidden>:
> > I would put approved merges proposed by the user at the top everywhere.
> > I am not sure I'd want approved merges by others on the active reviews
> > page at all. If it was there, I'd want it way, way below everything
> > else, because there's nothing I can do with it.
>
> You can encourage your team mates to merge them, or you can look into
> merging them yourself. So I think they should be shown all the same.
> You want to drive that stuff to zero just like you drive your own work
> to zero.
>
> I think eventually some level of filtering to show all reviews, only
> reviews I'm involved in, and other kinds of filtering may be good.
> But I do think it's important that people can always see the big
> picture, so I'd aim to get that right first then add filtering.
>
> --
> Martin <http://launchpad.net/~mbp/>

I guess there is also going to be
https://code.launchpad.net/people/+me/+activereviews
which will only show your own reviews, those approved and ready to land, those
reviews you have been requested to do, those you are doing, and those you are
waiting on.

Tim