Tim Penhey wrote:
> I was thinking about this exact think for the personal review page. For a
> personal one I'd tend to put the approved merges at the top because they
> should really be actioned as soon as possible (approved code that sits
> unmerged is a liability).
I would put approved merges proposed by the user at the top everywhere.
I am not sure I'd want approved merges by others on the active reviews
page at all. If it was there, I'd want it way, way below everything
else, because there's nothing I can do with it.
And we need filtering, so that people can find inactive reviews, too.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Tim Penhey wrote:
> I was thinking about this exact think for the personal review page. For a
> personal one I'd tend to put the approved merges at the top because they
> should really be actioned as soon as possible (approved code that sits
> unmerged is a liability).
I would put approved merges proposed by the user at the top everywhere.
I am not sure I'd want approved merges by others on the active reviews
page at all. If it was there, I'd want it way, way below everything
else, because there's nothing I can do with it.
And we need filtering, so that people can find inactive reviews, too.
Aaron enigmail. mozdev. org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkq KrwsACgkQ0F+ nu1YWqI3TQwCdEe dW1c653m2TLQlVn g05YmEe 9mBjY7rXuXPmJt7 SD
IUAAn0lSx2Rv4Zi
=6QQJ
-----END PGP SIGNATURE-----