Comment 1 for bug 411300

On Mon, 10 Aug 2009 20:08:14 Martin Pool wrote:
> Public bug reported:
>
> I'm finding that some merges seem to be "missing" from
> <https://code.edge.launchpad.net/bzr/+activereviews> - the reason being
> that they are now approved and therefore they have gone to
> <https://code.edge.launchpad.net/bzr/+approvedmerges>.
>
> I was originally going to just ask that there be a link from
> activereviews to approvedmerges, but on further consideration I don't
> think it makes sense for them to be separate at all. In both cases they
> represent work-in-progress or lean-waste that ought to be finished off;
> this is equally true whether the work is waiting for review, waiting for
> resubmission or waiting to merge.
>
> Activereviews currently shows things in all different states separated
> by headings and this works reasonably well. (Though the precise meaning
> of the headings is not totally clear.) I think it'd be best to just add
> one more heading, being approved reviews. Then if it's really wanted,
> as a separate item we can have some kind of filtering mechanism.

I was thinking about this exact think for the personal review page. For a
personal one I'd tend to put the approved merges at the top because they
should really be actioned as soon as possible (approved code that sits
unmerged is a liability).

Do you think that this would fit for projects too?

Tim