FFe request: samba 3.3.1

[Steve Langasek]

Binary package hint: samba

I'm requesting a Feature Freeze exception for a new upstream release of samba, bumping us from samba 3.3.0 to 3.3.1.

I would *not* characterize 3.3.1 as a bugfix-only microrelease, but it does include a number of bugfixes that are important, and there are also important bugfixes in the Debian 3.3.1-1 upload. The effort of cherry-picking the bugfixes we want would outweigh the risk of regression.

Upstream changelog:

Major enhancements in Samba 3.3.1 include:

     * Fix net ads join when "ldap ssl = start tls" (bug #6073).
     * Fix renaming/deleting of files using Windows clients (bug #6082).
     * Fix renaming/deleting a "not matching/resolving" symlink (bug #6090).
     * Fix remotely adding a share via the Windows MMC.

Changes since 3.3.0:
--------------------

o Jeremy Allison <email address hidden>
    * BUG 6082: Fix renaming/deleting of files using Windows clients.
    * BUG 6069: Fix build with too many arguments.
    * BUG 6090: Fix renaming/deleting a "not matching/resolving" symlink.
    * BUG 6099: Try to fix domain join of Win7 Beta.
    * BUG 6117: Fix core dump of pdbedit -a.
    * BUG 6133: Fix deletion of non-ACL files on Solaris/ZFS/NFSv4 ACL
      filesystem.
    * Fix Coverity IDs 115, 116, 117, 602.
    * Fix warning (bad handler prototype).
    * Unify the detection of the timespec code in configure.in, and the
      application of it in time.c.
    * Correctly use chroot().
    * Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure that "offered"
      read from the rpc packet in spoolss is under that size.
    * Backport the semantics of when to delete alternate data streams on a file
      truncate.
    * Fix printf warnings.
    * Fix warnings on Solaris.

o Michael Adam <email address hidden>
    * BUG 6066: netinet/ip.h present but cannot be compiled on Solaris.
    * BUG 6073: Prevent ads_connect() from using SSL unless explicitly
      requested.
    * Fix 'getent passwd' to allocate new uids.
    * Fix 'getent group' to allocate new gids.
    * Remove check for sharename being a username in 'net conf
      addshare'.

o Guenther Deschner <email address hidden>
    * Fix Coverity ID 848.
    * Remove unused ENUM_HND from 'net'.
    * Fix getform command asprintf return code in rpcclient.
    * Fix memleak in get_remote_printer_publishing_data().
    * Remove duplicate prototypes for generated rpc server functions.

o Holger Hetterich <email address hidden>
    * Enable total anonymization in vfs_smb_traffic_analyzer.

o Bjoern Jacke <email address hidden>
    * Fix build with external dns_sd libraries.
    * Fix configure check "sub-second timestamps without struct timespec".
    * Add configure check for AIX style sub-second resolution support.
    * Add configure check for Tru64 sub-second timestamp resolution.
    * Add Tru64 sub-second resolution timestamp support.
    * Enable IPv6 support for NetBSD and FreeBSD.
    * Use correct BSD evironment variable.

o Guenter Kukkukk <email address hidden>
    * Don't try and delete a default ACL from a file.

o Volker Lendecke <email address hidden>
    * BUG 5798: CFLAGS info lost in configure.
    * Fix Coverity IDs 740, 742, 744, 745, 876, 879, 880.
    * Fix remotely adding a share via the Windows MMC.
    * Avoid valgrind errors.
    * Fix 'net rpc join' for users with the SeMachineAccountPrivilege.
    * Fix resume handle for _samr_EnumDomainGroups.
    * Fix a buffer handling bug when adding lots of registry keys.
    * Fix a O(n^2) algorithm in regdb_fetch_keys().

o Jeff Layton <email address hidden>
    * Initialize rc to 0 in main in mount.cifs.

o Derrell Lipman <email address hidden>
    * BUG 6069: Add a fstatvfs function for libsmbclient.
    * Eliminate compiler warnings.

o Glenn Machin <email address hidden>
    * Don't miss an absolute pathname as a kerberos keytab path.

o Stefan Metzmacher <email address hidden>
    * BUG 6100: Implement _netr_LogonGetCapabilities() with
      NT_STATUS_NOT_IMPLEMENTED.
    * Make Samba work with older ctdb versions.
    * Add S-1-22-X-Y sids to the local token.

o Lars Mueller <email address hidden>
    * Conditional install of the cifs.upcall man page.
    * Adjust regex to match variable names including underscores.

o Shirish Pargaonkar <email address hidden>
    * BUG 4370: Clean-up entries in /etc/mtab after unmount.
    * Add fakemount (-f) and nomtab (-n) flags to mount.cifs.

o Ted Percival <email address hidden>
    * Fix a crash during name resolution.

o Tim Prouty <email address hidden>
    * Fix "assignment discards qualifiers from pointer target type"
      warnings.
    * Fix SMB_VFS_RECVFILE/SENDFILE macros.

o Karolin Seeger <email address hidden>
    * Change "ldap ssl:ads" parameter to "ldap ssl ads".
    * Add manpages for vfs_acl_xattr and vfs_acl_tdb.

o Dan Sledz <email address hidden>
    * Fix double free caused by incorrect talloc_steal usage.

o Simo Sorce <email address hidden>
    * Build ldbrename.

o Aravind Srinivasan <email address hidden>
    * Make nmbd check all available interfaces for WINS before failing.

o Miguel Suarez <email address hidden>
    * Fix compilation of vfs_default on systems that do not support utimes().

o Yasuma Takeda <email address hidden>
    * BUG 5920: Fix the calculation of the memcpy length.
    * BUG 6098: Fix ads_find_dc() in setups with "security = domain".

o Bo Yang <email address hidden>
    * Make libsmbclient work with DFS.

[Martin Pitt (pitti)]

Most of those are bug fixes, and the sum of those makes this very worthwhile. The only new feature that stands out to me is "Enable total anonymization in vfs_smb_traffic_analyzer."; this doesn't sound like a core feature, and since I doubt that it breaks compatibility with earlier releases it is okay.

Approved.

[Launchpad Janitor (janitor)]

This bug was fixed in the package samba - 2:3.3.1-1ubuntu1

---------------
samba (2:3.3.1-1ubuntu1) jaunty; urgency=low

  * Merge from Debian unstable (LP: #337094), remaining changes:
    + debian/patches/VERSION.patch:
      - setup SAMBA_VERSION_SUFFIX to Ubuntu.
    + debian/smb.conf:
      - add "(Samba, Ubuntu)" to server string.
      - comment out the default [homes] share, and add a comment about
        "valid users = %S" to show users how to restrict access to
        \\server\username to only username.
      - Set 'usershare allow guests', so that usershare admins are
        allowed to create public shares in addition to authenticated
        ones.
      - add map to guest = Bad user, maps bad username to guest access.
    + debian/samba-common.config:
      - Do not change priority to high if dhclient3 is installed.
      - Use priority medium instead of high for the workgroup question.
    + debian/mksambapasswd.awk:
      - Do not add user with UID less than 1000 to smbpasswd.
    + debian/control:
      - Make libwbclient0 replace/conflict with hardy's likewise-open.
      - Don't build against ctdb.
    + debian/rules:
      - enable "native" PIE hardening.
    + Add ufw integration:
      - Created debian/samba.ufw.profile
      - debian/rules, debian/samba.dirs, debian/samba.files: install
        profile
      - debian/control: have samba suggest ufw
  * Dropped changes, merged in Debian:
    + debian/libpam-smbpass.pam-config, debian/libpam-smbpass.postinst,
      debian/libpam-smbpass.prerm, debian/libpam-smbpass.files,
      debian/rules:
      - Make libpam-smbpasswd depend on libpam-runtime to allow
        libpam-smbpasswd for auto-configuration.
    + debian/control:
      - Provide a config block for the new PAM framework to auto-configure
        itself
    + debian/samba.postinst:
      - When populating the new sambashare group, it is not an error
        if the user simply does not exist; test for this case and let
        the install continue instead of aborting.
    + debian/winbind.files:
      - include additional files

samba (2:3.3.1-1) unstable; urgency=low

  [ Christian Perrier ]
  * New upstream release. Closes: #516981
    Upstream fixes in that release:
    - Fixed various spelling errors/typos in manpages
      Closes: #516047
    - Fix renaming/deleting of files using Windows clients.
      Closes: #516160
    - Fix syntax error in mount.cifs(8). Closes: #454799
  * Use a slave alternative for smbstatus.1 even though that manpage
    is not provided by samba4

  [ Jelmer Vernooij ]
  * Fix slave links for manual pages in samba-common. Closes: #517204.

  [ Steve Langasek ]
  * Add Vcs-{Browser,Svn} fields to debian/control.
  * When populating the sambashare group, it's not an error if the user
    simply doesn't exist; test for this case and let the install continue
    instead of aborting. LP: #206036.
  * debian/libpam-smbpass.pam-config, debian/libpam-smbpass.postinst,
    debian/libpam-smbpass.files, debian/rules: provide a config block
    for the new PAM framework, allowing this PAM module to
    auto-configure itself
  * debian/control: make libpam-smbpass depend on
    libpam-runtime ...