[SRU] Backport 2022.01-2022.1-update3+repack-0ubuntu1 to kinetic and jammy

Bug #2006448 reported by ethan.hsieh
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
u-boot-xlnx (Ubuntu)
New
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
1. Ugrade u-boot-xlnx from 2020.2 to 2022.1_update3 as per Xilinx's request.
https://github.com/Xilinx/u-boot-xlnx/tree/xlnx_rebase_v2022.01_2022.1_update3
2. Add Versal VCK190 board support

[Test Plan]
1. Changes between 2020.2 and 2022.1-update3.
Xilinx has verified u-boot (2022.1-update3) on ZCU102/104/106 and passed all test cases.
Test cases: Please see the attached file in comment#7

2. Install u-boot-xlnx on VCK190/ZCU102/104/106 and check if system can boot to kernel without any problems.

[Where problems could occur]
u-boot-xlnx (2022.1_update3) are released and verified by AMD-Xilinx. It should be low risk.

[Other information]

3. changes in debian/
3.1 d/patches:
a. Remove 0001-Fix-build-for-hirsute.patch:
It's a patch for build failure on hirsute. Lunar/Kinetic/jammy don't need it.
b. Add add-debian-revision-to-u-boot-version
No risk. Just add debian revision to u-boot version.
c. fix-versal-random-mac-issue.patch
It's a patch provided by Xilinx for a known issue on u-boot (2022.1-update3).
3.2 Remove d/u-boot-zynqmp.postinst and d/script/boot.cmd
No risk. U-Boot boot script should come from flash-kernel since focal.
u-boot-zynqmp.postinst is used for generating boot.scr.uimg based on boot.cmd. boot.cmd is out-of-date and system cannot boot with this boot script. They're unnecessary files. both u-boot-zynqmp.postinst and boot.cmd must be removed from the package.
3.3 Update d/copyright for u-boot (2022.1-update3)
No risk.
3.4 Update d/targets to add support for Versal VCK190
No regression issue becuase VCK190 is a new board.
3.5 Update d/watch to check tags instead of releases and repack to remove excluded files.
No risk.

tags: added: oem-priority originate-from-1971661
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Failed to create correct debdiff files because of [1]. So, I created a git repo for SRU. Please see [2] & [3].

I verified following test packages[4] with two boards (Versal VCK190 and ZCU102).
1. kinetic: 2022.01-2022.1-update3+repack-0ubuntu0~22.04
2. jammy: 2022.01-2022.1-update3+repack-0ubuntu0~22.10
System can boot with both of them without problems.

---
[1] https://bugs.launchpad.net/ubuntu/+source/u-boot-xlnx/+bug/2002473/comments/6
[2] patches for kinetic, https://code.launchpad.net/~ethan.hsieh/+git/u-boot-xlnx/+ref/kinetic
[3] patches for jammy, https://code.launchpad.net/~ethan.hsieh/+git/u-boot-xlnx/+ref/jammy
[4] Test packages: https://launchpad.net/~ethan.hsieh/+archive/ubuntu/sru

Revision history for this message
Dave Jones (waveform) wrote :

I've had a look at the kinetic and jammy branches and built them both on amd64. There's a couple of lintian errors that could be overridden but they're definite false-positives (warnings about arch-dependent / statically-linked binaries in the u-boot binary outputs), so I'm happy to ignore those and just upload as is.

Dave Jones (waveform)
summary: - Backport 2022.01-2022.1-update3+repack-0ubuntu1 to kinetic and jammy
+ [SRU] Backport 2022.01-2022.1-update3+repack-0ubuntu1 to kinetic and
+ jammy
Revision history for this message
Dave Jones (waveform) wrote :
Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of u-boot-xlnx to kinetic-proposed has been rejected from the upload queue for the following reason: "Extensive changes to debian/ packaging, not covered by HWE policy, no test case or rationale".

Revision history for this message
Steve Langasek (vorlon) wrote :

An upload of u-boot-xlnx to jammy-proposed has been rejected from the upload queue for the following reason: "Extensive changes to debian/ packaging, not covered by HWE policy, no test case or rationale".

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Hi Steve,

Here is the test plan in bug description:
1. u-boot-xlnx (2022.1_update3) has been verified by AMD-Xilinx.
2. Install u-boot-xlnx on Versal and ZCU boards and check if system can boot to kernel without any problems.

Did I miss something? May I know the detailed rejection reason? Thanks~

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :
description: updated
description: updated
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Hi Steve,
I have updated the bug description to add information about regression tests. Please let me know if you still have concern. Thanks~

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This is obviously a bit of a troublesome change to review and parse, especially with the diff being 10M. But seeing that this package is device-specific, and with the additionally provided context in the description regarding the debian/ changes, I feel a bit more confident to include this into -proposed.

However, I would like Xilinx to re-test the packages that will be made available in kinetic-proposed and jammy-proposed, if possible.

description: updated
Changed in u-boot-xlnx (Ubuntu Kinetic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello ethan.hsieh, or anyone else affected,

Accepted u-boot-xlnx into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/u-boot-xlnx/2022.01-2022.1-update3+repack-0ubuntu1~22.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

hmmm, for the jammy SRU, I also see and additional change in the debian/ directory that's not mentioned here. Before accepting I'd like to know the rationale. It seems like debian/u-boot-zynqmp.postinst is being removed. Can you give a bit more context on that one?

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

@Łukasz

Sorry for not explaining sufficiently. u-boot-zynqmp.postinst is used for generating boot.scr.uimg based on boot.cmd. boot.cmd is out-of-date and system cannot boot with this boot script. So, both u-boot-zynqmp.postinst and boot.cmd must be removed from the package.

Bug Description:
3. changes in debian/
3.2 Remove d/script/boot.cmd
No risk. boot.cmd is out-of-date. System cannot boot with this boot script. It's an unnecessary file. U-Boot boot script comes from flash-kernel since focal.

description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello ethan.hsieh, or anyone else affected,

Accepted u-boot-xlnx into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/u-boot-xlnx/2022.01-2022.1-update3+repack-0ubuntu1~22.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in u-boot-xlnx (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed-jammy
description: updated
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Verified following packages on VCK190/ZCU102/104/106.
Kinetic: u-boot-xlnx (2022.01-2022.1-update3+repack-0ubuntu1~22.10)
Jammy: u-boot-xlnx (2022.01-2022.1-update3+repack-0ubuntu1~22.04)

Here is the test result:
1. VCK190
kinetic: Pass
jammy: Pass
2. ZCU102/104/106
kinetic: Pass
jammy: Pass
System can boot to kernel. DP, USB keyboard, and Ethernet work well.

tags: added: verification-done-jammy verification-done-kinetic
removed: verification-needed-jammy verification-needed-kinetic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

As discussed in person, this SRU update should be verified alongside https://bugs.launchpad.net/ubuntu/+source/xlnx-firmware/+bug/2006104 , using both the binary packages coming from the -proposed pockets. Reverting the verification-done tags in this case.

Also, as we also discussed, please do (and document) additional testing done for this upload, aka. any possible functional testing (wifi, basic usage etc.) on all the supported devices to decrease the regression potential due to being a big u-boot version bump.

tags: added: verification-needed-jammy verification-needed-kinetic
removed: verification-done-jammy verification-done-kinetic
Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :

Have requested AMD-Xilinx to run U-Boot related tests on ZCU/VCK boards with packages in kinetic/jammy-proposed. Will upload test results once I get them from AMD-Xilinx QA team.

Revision history for this message
ethan.hsieh (ethan.hsieh) wrote :
tags: added: verification-done
removed: verification-needed
tags: added: verification-done-jammy verification-done-kinetic verification-needed
removed: verification-done verification-needed-jammy verification-needed-kinetic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for u-boot-xlnx has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package u-boot-xlnx - 2022.01-2022.1-update3+repack-0ubuntu1~22.10

---------------
u-boot-xlnx (2022.01-2022.1-update3+repack-0ubuntu1~22.10) kinetic; urgency=medium

  * Backport to kinetic (LP: #2006448)

 -- Ethan Hsieh <email address hidden> Thu, 19 Jan 2023 14:19:37 +0800

Changed in u-boot-xlnx (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package u-boot-xlnx - 2022.01-2022.1-update3+repack-0ubuntu1~22.04

---------------
u-boot-xlnx (2022.01-2022.1-update3+repack-0ubuntu1~22.04) jammy; urgency=medium

  * Backport to jammy (LP: #2006448)

 -- Ethan Hsieh <email address hidden> Thu, 19 Jan 2023 14:24:23 +0800

Changed in u-boot-xlnx (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.