[SRU] Add Versal VCK190 support

[ethan.hsieh]

[Impact]
Add Versal VCK190 support (Create xlnx-versal-firmware package for Versal boards)

Update xlnx-firmware to tag/v2022.1_22.04_4 for VCK190 as per Xilinx's request.
https://github.com/Xilinx/ubuntu-firmware/tree/v2022.1_22.04_4

[Test Plan]
1. VCK190: There is no regression issue because the package will add initial support for VCK190. Here are test cases for VCK190:
1.1 boot1901.bin for vck190 can be generated by xilinx-bootgen.
1.2 system can boot with boot1901.bin
1.3 check if the basic functions (ethernet, usb, uart) can work.

2. ZCU baords (zcu102, 104, 106, 111): Firmware for ZCU boards are unchanged. But, the following tests will be done to make sure the packaging is valid.
2.1 checksum of firmware are unchanged.
2.2 bootX.bin can be generated by xilinx-bootgen.
2.3 System can boot without any problem.
2.4 check if the basic functions (ethernet, usb, uart) can work.

[Where problems could occur]
Adds support for a new board (VCK190) with updated firmware. Whilst it would appear that this is an overall new firmware version, binary diff of the orig tarballs confirms that the firmware for the existing ZCU* boards is actually unchanged so the risk of regression on those boards should be minimal (it should still be tested to ensure the packaging is valid, however).

[ethan.hsieh (ethan.hsieh)]

Failed to upload the patch file to LP because the size is larger than 40MB. So, I created a git repo[1].

---
[1] The git repo for adding Versal VCK190 support, https://code.launchpad.net/~ethan.hsieh/+git/xlnx-firmware/+ref/master
[2] Test package. xlnx-firmware - 2022.1-4-0ubuntu1, https://launchpad.net/~ethan.hsieh/+archive/ubuntu/sru-test/+packages

[ethan.hsieh (ethan.hsieh)]

Created two branches (kinetic and jammy) on [1] for kinetic and jammy SRUs.

Verified test packages[2] on VCK190 and ZCU102. System can boot with new bootX.bin without any problems.
1. ZCU102
xlnx-firmware (2022.1-4-0ubuntu1~22.04): Pass
xlnx-firmware (2022.1-4-0ubuntu1~22.10): Pass
2. VCK190
xlnx-versal-firmware (2022.1-4-0ubuntu1~22.04): Pass
xlnx-versal-firmware (2022.1-4-0ubuntu1~22.10): Pass

xlnx-versal-firmware depends on u-boot-xlnx >= 2022.01-2022.1-update3+repack-0ubuntu1~. The new u-boot must be available on kinetic and jammy (#2006448) when xlnx-versal-firmware lands to kinetic and jammy.

---
[1] https://code.launchpad.net/~ethan.hsieh/+git/xlnx-firmware/
[2] https://launchpad.net/~ethan.hsieh/+archive/ubuntu/sru-test

[Dave Jones (waveform)]

There's a few issues with the lunar upload; most are minor (false positives on lintian errors, unsurprisingly given it's bootloader firmware and therefore mismatches on arch and warns about static linkage) and I've just patched them locally to suppress them. However, one (despite being a warning) is rather more important:

W: xlnx-firmware source: binaries-have-file-conflict xlnx-firmware xlnx-versal-firmware lib/firmware/xilinx/xilinx-hdmi-rx-edid.bin

In other words, both xlnx-firmware and xlnx-versal-firmware provide /lib/firmware/xilinx/xilinx-hdmi-rx-edid.bin so both conflict. I'm assuming that's intended? In that case we just need to add a Conflicts: line to each package to make sure they can't both be installed simultaneously. If that's not intended then it'll need to be fixed (I'm guessing the fix is that xlnx-firmware is the over-arching package and should be the one to provide the EDID file?).

[ethan.hsieh (ethan.hsieh)]

Hi Dave

Both xlnx-firmware and xlnx-versal-firmware have xilinx-hdmi-rx-edid.bin. It's intended. xlnx-firmware is for ZCU boards when xlnx-versal-firmware is for Versal boards. I don't expect they're installed on the same device. I'll add a Conflicts: line to prevent users from installing them on the same device accidentally.

[ethan.hsieh (ethan.hsieh)]

Hi Dave,

I have submitted patches to [1] and verified the test package. xlnx-firmware will be removed if I install xlnx-versal-firmware.

---
[1] https://code.launchpad.net/~ethan.hsieh/+git/xlnx-firmware/

[Dave Jones (waveform)]

Excellent, thanks. I've tweaked a couple of minor bits (added bug ref in the changelog, and fixed up a couple of spurious lintian warnings), and added an attempt at a d/watch file which may make it a little easier to grab updated firmwares in future. This should now be uploaded for lunar; I'll convert the ticket for SRU in a mo.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xlnx-firmware - 2022.1-4-0ubuntu1

---------------
xlnx-firmware (2022.1-4-0ubuntu1) lunar; urgency=medium

  * Update firmware to tag v2022.1_22.04_4 (LP: #2006104)
  * Add Versal VCK190 support

 -- Ethan Hsieh <email address hidden> Fri, 13 Jan 2023 15:14:37 +0800

[ethan.hsieh (ethan.hsieh)]

SRU (backport the package to kinetic and jammy) is blocked by LP: #2006448 and LP: #2012469

[ethan.hsieh (ethan.hsieh)]

1. LP: #2006448: u-boot-xlnx (2022.01-2022.1-update3+repack-0ubuntu1) is available on kinetic/jammy-proposed and will be landed to -updates soon.

2. LP: #2012469: The fix is available on lunar.

Above two blocking issues have been resolved. I've updated [1] for xlnx-firmware SRU.

---
[1] https://code.launchpad.net/~ethan.hsieh/+git/xlnx-firmware/

[Dave Jones (waveform)]

I've tweaked the changelogs so they didn't miss out entries that were previously in jammy & kinetic (specifically the last SRUs), and fixed the standards-version in each case (4.6.2 is beyond kinetic & jammy's lintian versions), and the jammy lintian overrides (which have changed style since 4.6.0.1).

These should now be uploaded to the jammy & kinetic queues.

[ethan.hsieh (ethan.hsieh)]

@Dave Thanks~

[Łukasz Zemczak (sil2100)]

Hello ethan.hsieh, or anyone else affected,

Accepted xlnx-firmware into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xlnx-firmware/2022.1-4-0ubuntu2~22.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello ethan.hsieh, or anyone else affected,

Accepted xlnx-firmware into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/xlnx-firmware/2022.1-4-0ubuntu2~22.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

As mentioned in https://bugs.launchpad.net/ubuntu/+source/u-boot-xlnx/+bug/2006448 , please verify both of the bugs (and packages) at the same time, providing verification evidence accordingly. Thanks!

[ethan.hsieh (ethan.hsieh)]

Hi Łukasz,

1. Upgarde xlnx-firmware to 2022.1-4-0ubuntu2~22.10 and 2022.1-4-0ubuntu2~22.04
Follow test steps in the bug description to verify new package on ZCU boards. All tests are pass.

2. Install xlnx-versal-firmware 2022.1-4-0ubuntu2~22.10 and 2022.1-4-0ubuntu2~22.04 on VCK190.
Follow test steps in the bug description to verify new package on VCK190 board. All tests are pass.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for xlnx-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package xlnx-firmware - 2022.1-4-0ubuntu2~22.10

---------------
xlnx-firmware (2022.1-4-0ubuntu2~22.10) kinetic; urgency=medium

  * SRU to kinetic (LP: #2006104)
    - Fix: fail to load *.xclbin because of the wrong symbolic link name.
      The symbolic link name should be /usr/lib/dpu.xclbin
    - Update firmware to tag v2022.1_22.04_4
    - Add Versal VCK190 support
    - Change dependency to favour xilinx-bootgen over bootgen-xlnx

      xilinx-bootgen created by Debian Project official developer is
      available on Debian and Ubuntu archives. So, xlnx-firmware should use
      xilinx-bootgen instead of bootgen-xlnx maintained by Canonical.
  * Drop standards version to 4.6.1

 -- Ethan Hsieh <email address hidden> Mon, 24 Apr 2023 11:27:24 +0800

[Launchpad Janitor (janitor)]

This bug was fixed in the package xlnx-firmware - 2022.1-4-0ubuntu2~22.04

---------------
xlnx-firmware (2022.1-4-0ubuntu2~22.04) jammy; urgency=medium

  * SRU to jammy (LP: #2006104)
    - Update firmware to tag v2022.1_22.04_4
    - Add Versal VCK190 support
    - Change dependency to favour xilinx-bootgen over bootgen-xlnx

      xilinx-bootgen created by Debian Project official developer is
      available on Debian and Ubuntu archives. So, xlnx-firmware should use
      xilinx-bootgen instead of bootgen-xlnx maintained by Canonical.
  * Dropped standards version to 4.6.0.1
  * Revised lintian overrides for older version

 -- Ethan Hsieh <email address hidden> Wed, 08 Feb 2023 14:26:26 +0800