Call Number Missing condition can be bypassed

[Jason Etheridge]

On a test system running today's master with concerto data, in the web client with a BR1 workstation and the admin user, I can do:

Cataloging -> Retrieve Record By ID -> 1 -> Submit
Add Copies

And get a pre-populated volume row with the Call Number: ML'2533'B34'C3'1989

If I select and delete the ML'2533'B34'C3'1989, I'll get a red Missing Call Number indicator and the Save buttons will disable until rectified. But if I click on Add Volumes, I'll get a new row without a pre-populated Call Number value, and without the Save buttons being disabled.

If I use such a blank call number and try to create an item, it'll silently fail in the UI and under the hood will give an error like this:

open-ils.cstore ERROR inserting asset::call_number object using query [INSERT INTO asset.call_number (create_date,creator,deleted,edit_date,editor,id,label,owning_lib,record,label_sortkey,label_class,prefix,suffix) VALUES ('now',1,DEFAULT,'now',1,DEFAULT,DEFAULT,4,1,DEFAULT,DEFAULT,-1,-1);]: 3452548 3452548: ERROR: query string argument of EXECUTE is null

We may want to pre-populate the Call Number label field for all dynamically added rows, however, we'll also need to consider that not all bib records will contain the necessary call number data to do so, so that change alone would not be a sufficient fix.

[Kathy Lussier (klussier)]

Do you think this may be the same bug as the one reported in bug 1713164? In that case, we encountered the problem on a record that didn't have the MARC fields that would result in an automatically-generated call number.