gnome-shell crashed with SIGABRT in st_bin_destroy: assertion failed: (priv->child == NULL) called from DesktopManager::_destroyDesktopIcons() [desktopManager.js:234]

[Peter Freeman]

[Impact]

Gnome Shell crashes at random times when the Desktop or home directory is modified, and the desktop-icons extension tries to refresh.

https://errors.ubuntu.com/problem/fcc5c581fc0a8c2f8f68314fa383690423a3dc02

[Test Case]

Open a nautilus (Files) window and tap Ctrl+H repeatedly. The shell should not crash or freeze.

[Where problems could occur]

An extension with syntax errors may fail to load leaving the user with reduced shell functionality. A more faulty extension might crash the entire shell after loading, like this bug.

[Other Info]

See also bug 1898910

---

Sorry, I missed what was happening when this crashed. I'll try to catch it next time.

ProblemType: Crash
DistroRelease: Ubuntu 20.10
Package: gnome-shell 3.38.0-1ubuntu2
ProcVersionSignature: Ubuntu 5.8.0-18.19-generic 5.8.4
Uname: Linux 5.8.0-18-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu48
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Wed Sep 30 08:38:45 2020
DisplayManager: gdm3
ExecutablePath: /usr/bin/gnome-shell
ProcCmdline: /usr/bin/gnome-shell
ProcEnviron:
 LANG=en_CA.UTF-8
 LANGUAGE=en_CA:en
 PATH=(custom, no user)
 SHELL=/bin/bash
 XDG_RUNTIME_DIR=<set>
RelatedPackageVersions: mutter-common 3.38.0-1ubuntu1
Signal: 6
SourcePackage: gnome-shell
StacktraceTop:
 () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
 g_assertion_message_expr () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
 () at /usr/lib/gnome-shell/libst-1.0.so
 g_closure_invoke () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
 () at /lib/x86_64-linux-gnu/libgobject-2.0.so.0
Title: gnome-shell crashed with SIGABRT
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin lxd plugdev sambashare sudo
separator:

[Apport retracing service (apport)]

StacktraceTop:
 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49
 __GI_abort () at abort.c:79
 g_assertion_message.cold () from /tmp/apport_sandbox_0ug6usw6/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.0
 g_assertion_message_expr () from /tmp/apport_sandbox_0ug6usw6/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6600.0
 st_bin_destroy () from /tmp/apport_sandbox_0ug6usw6/usr/lib/gnome-shell/libst-1.0.so

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Daniel van Vugt (vanvugt)]

See also bug 1898910.

[Greg Lehto (gnl221)]

I was using nautilus to connect with ssh to a local server when it crashed for me. As soon as I hit enter after putting in my credentials the screen flickered a few times.

[Marco Trevisan (Treviño) (3v1n0)]

Got the same once applied the change to enable fractional scaling in a new NVIDIA install:

oct 20 18:18:05 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: clutter_actor_add_child: assertion 'child->priv->parent == NULL' failed
oct 20 18:18:05 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: clutter_actor_add_child: assertion 'child->priv->parent == NULL' failed
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: **
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: Bail out! St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: GNOME Shell crashed with signal 6
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: == Stack trace for context 0x564279be6220 ==
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #0 56427fe2b978 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:206 (733f007f880 @ 142)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #1 56427fe2b8f0 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:124 (733f007fa10 @ 12)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #2 56427fe2b850 i resource:///org/gnome/shell/ui/background.js:695 (1b5fcce13d0 @ 155)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #3 7ffc06bbc920 b resource:///org/gnome/shell/ui/layout.js:471 (1b5fcce06a0 @ 74)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #4 56427fe2b7b8 i resource:///org/gnome/shell/ui/layout.js:541 (1b5fcce04c0 @ 62)
oct 20 18:18:07 marco-HP-Pavilion-Notebook-15-bc5xxx gnome-shell[1625]: #5 7ffc06bbd480 b self-hosted:850 (15cca1b07510 @ 423)

Crash with debug symbols: https://paste.ubuntu.com/p/9bzFwV2yXs/ (full backtrace https://paste.ubuntu.com/p/28pVghG8XZ/)

[Aleksander Miera (amiera)]

Same when using DisplayLink adapter via both EVDI or UDL. Crashes most of the times when GPU file (/dev/dri/cardX) is created. Gnome logs:

dladmin-XPS-13-9360 gnome-shell[3367]: St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
dladmin-XPS-13-9360 gnome-shell[3367]: Bail out! St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
dladmin-XPS-13-9360 gnome-shell[3367]: GNOME Shell crashed with signal 6
dladmin-XPS-13-9360 gnome-shell[3367]: == Stack trace for context 0x55b2530dd150 ==
dladmin-XPS-13-9360 gnome-shell[3367]: #0 55b2549ae9d8 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:206 (2d1dccd7c880 @ 142)
dladmin-XPS-13-9360 gnome-shell[3367]: #1 55b2549ae950 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopGrid.js:124 (2d1dccd7ca10 @ 12)
dladmin-XPS-13-9360 gnome-shell[3367]: #2 7ffe81569ef0 b resource:///org/gnome/shell/ui/background.js:695 (1caa9dce13d0 @ 155)
dladmin-XPS-13-9360 gnome-shell[3367]: #3 7ffe81569fb0 b resource:///org/gnome/shell/ui/layout.js:471 (1caa9dce06a0 @ 74)
dladmin-XPS-13-9360 gnome-shell[3367]: #4 55b2549ae8b8 i resource:///org/gnome/shell/ui/layout.js:541 (1caa9dce04c0 @ 62)
dladmin-XPS-13-9360 gnome-shell[3367]: #5 7ffe8156aa80 I self-hosted:850 (341e9140a600 @ 423)

GDB backtrace attached.

[Aditya Suseno (aditya-suseno)]

Got this bug after upgrading to 20.10
Using Gnome Shell 3.38.1 and Mutter 3.38.1

Frequent crash in wayland session
Especially when pressing save button dialogue

gnome-shell[2119]: **
gnome-shell[2119]: St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
gnome-shell[2119]: Bail out! St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
gnome-shell[2119]: GNOME Shell crashed with signal 6
gnome-shell[2119]: == Stack trace for context 0x5645ba824140 ==
gnome-shell[2119]: #0 5645bae046e0 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:234 (d0258b7b>
gnome-shell[2119]: #1 7ffcbfc591d0 b self-hosted:225 (1f8f4c1a5d80 @ 273)
gnome-shell[2119]: #2 5645bae04648 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:234 (d0258b7b>
gnome-shell[2119]: #3 5645bae045b8 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:209 (d0258b7b>
gnome-shell[2119]: #4 5645bae044b8 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:460 (d0258b7b>
gnome-shell[2119]: #5 5645bae04418 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:340 (d0258b7b

[Fabian Meumertzheim (fmeum)]

I am also experiencing this bug. I can reproduce it every time by unmounting and then mounting an external drive in Files. The log output:

udisksd[1564]: udisks_state_check_mounted_fs_entry: block device /dev/sda1 is busy, skipping cleanup
systemd[942289]: media-fhenneke-Build.mount: Succeeded.
systemd[1]: media-fhenneke-Build.mount: Succeeded.
udisksd[1564]: Cleaning up mount point /media/fhenneke/Build (device 8:1 is not mounted)
udisksd[1564]: Unmounted /dev/sda1 on behalf of uid 1000
gnome-shell[942459]: **
gnome-shell[942459]: St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
gnome-shell[942459]: Bail out! St:ERROR:../src/st/st-bin.c:206:st_bin_destroy: assertion failed: (priv->child == NULL)
gnome-shell[942459]: GNOME Shell crashed with signal 6
gnome-shell[942459]: == Stack trace for context 0x55da423db100 ==
gnome-shell[942459]: #0 55da43efe1c8 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:234 (3d4a1c3cc650 @ 10)
gnome-shell[942459]: #1 7ffe24a8d620 b self-hosted:225 (34d163856240 @ 273)
gnome-shell[942459]: #2 55da43efe130 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:234 (3d4a1c3cc6a0 @ 43)
gnome-shell[942459]: #3 55da43efe0a0 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:209 (3d4a1c3cc7e0 @ 32)
gnome-shell[942459]: #4 55da43efe018 i /usr/share/gnome-shell/extensions/desktop-icons@csoriano/desktopManager.js:96 (3d4a1c3ccb50 @ 12)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Daniel van Vugt (vanvugt)]

First attempt at a fix: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1500

[Daniel van Vugt (vanvugt)]

OK, I've proposed a fix for the root cause here:

  https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/merge_requests/191

but it still scares me how easily StBin failed to notice such a mistake so I might also add some error checking in gnome-shell to prevent similar mistakes going unnoticed.

[Daniel van Vugt (vanvugt)]

And this one too:

  https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1507

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0+git20200908-5

---------------
gnome-shell-extension-desktop-icons (20.04.0+git20200908-5) unstable; urgency=medium

  [ Daniel van Vugt ]
  * Add fix-lp1898462.patch to fix broken drag-and-drop (LP: #1898462)

  [ Iain Lane ]
  * Rename fix-*.patch to more descriptive names following their commit
    subjects

 -- Iain Lane <email address hidden> Mon, 07 Dec 2020 18:16:04 +0000

[Daniel van Vugt (vanvugt)]

Here's a patch specifically for groovy. If anyone wants to ignore it and do a sync from Debian instead then that's fine by me.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.2-1ubuntu1

---------------
gnome-shell (3.38.2-1ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1908161):
    - Fixed crash in meta_window_actor_thaw (LP: #1897765)
    - Fixed crash in st_bin_destroy (LP: #1898005)
  * debian/patches:
    - Refreshed
    - Revert-appDisplay-baseAppView-Cleanup-animate.patch:
      + Revert a 3.38.2 change that proved to cause regressions
    - screenshot-Grab-screenshot-during-paint-on-X11.patch:
      + Correctly take screenshots for fullscreen games (LP: #1908164)
  * Remaining changes with debian:
    - Replace gnome-backgrounds dep with ubuntu-wallpapers and Suggests
      gnome-themes-standard-data, gnome-backgrounds
    - Add some Recommends:
      + ubuntu-session (| gnome-session) to have the ubuntu session available
      + xserver-xorg-legacy
      + yaru-theme-gnome-shell for the default ubuntu theming
    - Update debian/gbp.conf with Ubuntu settings
    - gnome-shell-common.prerm: Remove deprecated ubuntu theme alternative
    - ubuntu/desktop_detect.patch:
      + add caching for desktop detection to avoid querying the current
        desktop env variable as iterate through the list each time. For the
        time of the Shell process, we can expect this env variable to stay
        stable.
    - ubuntu/smarter_alt_tab.patch:
      + quick alt-tab (without showing up the switcher) switch only between
        the last window of the last 2 applications to be focused instead of
        raising all windows of those apps.
    - ubuntu/lightdm-user-switching.patch:
      + Allow user switching when using LightDM.
    - ubuntu/lock_on_suspend.patch
      + Respect Ubuntu's lock-on-suspend setting.
    - ubuntu/background_login.patch
      + Change default background color as we modified the default GDM color
        for our ubuntu session.
    - ubuntu/gdm_alternatives.patch
      + Add support for GDM3 theme alternatives
    - optional-hot-corner.patch
      + enable patch proposed by upstream developer already in package (but
        not in series) to add a settings for optional hot corner activation.
    - main-show-an-error-message-on-gnome-shell-crash.patch,
      global-make-possible-to-set-debug-flags-dynamically.patch,
      main-increase-the-granularity-of-backtraces-in-SHELL_DEBU.patch,
      main-add-backtrace-crashes-all-and-backtrace-all.patch,
      sessionMode-add-support-for-debugFlags-parameter.patch:
      + Improve debug JS tracing for crash reports
    - st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch:
      + Fix crash on theme changes
    - ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
      + stop searches when requested from UI
    - magnifier-Show-cursor-when-magnifier-is-enabled-and-scale.patch:
      + Show monitor scaled cursor when magnifier is enabled
    - Break gnome-shell-extension-desktop-icons (<< 19.01.3+git20190814)

gnome-shell (3.38.2-1) unstable; urgency=medium

  * Team upload
  * New upstream release
    - Improve app picker spacing on larger resolutions
    - Don't add dialogs to the window preview more than once
    - ...

[Timo Aaltonen (tjaalton)]

Hello Peter, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/20.04.0+git20200908-5~ubuntu20.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Peter, or anyone else affected,

Accepted gnome-shell into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.38.2-1ubuntu1~20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andreas Kübrich (akuebrich)]

Tested in a Wayland session with gnome-shell 3.38.2-1ubuntu1~20.10.1 and gnome-shell-extension-desktop-icons 20.04.0+git20200908-5~ubuntu20.10.0. Neither changing display resolution nor `touch ~/Desktop/test` nor Ctrl+H in Nautilus crashes the shell any more. Whether the previous seemingly random crashes still happen, I cannot say.

[Marian Rainer-Harbach (marianrh)]

Since Andreas Kübrich (akuebrich) has verified the fix I'll go ahead and set the verification-done-groovy tag.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0+git20200908-5~ubuntu20.10.0

---------------
gnome-shell-extension-desktop-icons (20.04.0+git20200908-5~ubuntu20.10.0) groovy; urgency=medium

  * No-change backport to groovy

gnome-shell-extension-desktop-icons (20.04.0+git20200908-5) unstable; urgency=medium

  [ Daniel van Vugt ]
  * Add fix-lp1898462.patch to fix broken drag-and-drop (LP: #1898462)

  [ Iain Lane ]
  * Rename fix-*.patch to more descriptive names following their commit
    subjects

gnome-shell-extension-desktop-icons (20.04.0+git20200908-4) unstable; urgency=medium

  * Add fix-lp1898462.patch to fix broken drag-and-drop (LP: #1898462).

gnome-shell-extension-desktop-icons (20.04.0+git20200908-3) unstable; urgency=medium

  * Add fix-lp1898005.patch to fix crashes in st_bin_destroy (LP: #1898005).

gnome-shell-extension-desktop-icons (20.04.0+git20200908-2) unstable; urgency=medium

  * Upload to unstable

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 15 Dec 2020 00:24:29 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.2-1ubuntu1~20.10.1

---------------
gnome-shell (3.38.2-1ubuntu1~20.10.1) groovy; urgency=medium

  * No-change backport to groovy
  * debian: Update gbp.conf and control references to groovy branching

gnome-shell (3.38.2-1ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1908161):
    - Fixed crash in meta_window_actor_thaw (LP: #1897765)
    - Fixed crash in st_bin_destroy (LP: #1898005)
  * debian/patches:
    - Refreshed
    - Revert-appDisplay-baseAppView-Cleanup-animate.patch:
      + Revert a 3.38.2 change that proved to cause regressions
    - screenshot-Grab-screenshot-during-paint-on-X11.patch:
      + Correctly take screenshots for fullscreen games (LP: #1908164)
  * Remaining changes with debian:
    - Replace gnome-backgrounds dep with ubuntu-wallpapers and Suggests
      gnome-themes-standard-data, gnome-backgrounds
    - Add some Recommends:
      + ubuntu-session (| gnome-session) to have the ubuntu session available
      + xserver-xorg-legacy
      + yaru-theme-gnome-shell for the default ubuntu theming
    - Update debian/gbp.conf with Ubuntu settings
    - gnome-shell-common.prerm: Remove deprecated ubuntu theme alternative
    - ubuntu/desktop_detect.patch:
      + add caching for desktop detection to avoid querying the current
        desktop env variable as iterate through the list each time. For the
        time of the Shell process, we can expect this env variable to stay
        stable.
    - ubuntu/smarter_alt_tab.patch:
      + quick alt-tab (without showing up the switcher) switch only between
        the last window of the last 2 applications to be focused instead of
        raising all windows of those apps.
    - ubuntu/lightdm-user-switching.patch:
      + Allow user switching when using LightDM.
    - ubuntu/lock_on_suspend.patch
      + Respect Ubuntu's lock-on-suspend setting.
    - ubuntu/background_login.patch
      + Change default background color as we modified the default GDM color
        for our ubuntu session.
    - ubuntu/gdm_alternatives.patch
      + Add support for GDM3 theme alternatives
    - optional-hot-corner.patch
      + enable patch proposed by upstream developer already in package (but
        not in series) to add a settings for optional hot corner activation.
    - main-show-an-error-message-on-gnome-shell-crash.patch,
      global-make-possible-to-set-debug-flags-dynamically.patch,
      main-increase-the-granularity-of-backtraces-in-SHELL_DEBU.patch,
      main-add-backtrace-crashes-all-and-backtrace-all.patch,
      sessionMode-add-support-for-debugFlags-parameter.patch:
      + Improve debug JS tracing for crash reports
    - st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch:
      + Fix crash on theme changes
    - ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
      + stop searches when requested from UI
    - magnifier-Show-cursor-when-magnifier-is-enabled-and-scale.patch:
      + Show monitor scaled cursor when magnifier is enabled
    - Break gnome-shell-extension-desktop-icons (<< 19.01.3+git20190814)

gnome-shell (3.38.2-1) unstable; urge...

[Daniel van Vugt (vanvugt)]

Here's a fix for focal.

[Daniel van Vugt (vanvugt)]

I had to bypass Debian salsa git because the existing focal version isn't in there.

[Daniel van Vugt (vanvugt)]

The fixes for focal are:

gnome-shell: upstream, scheduled for release in future version 3.36.9

gnome-shell-extension-desktop-icons: patch proposed in comment #28

[Daniel van Vugt (vanvugt)]

Note the gnome-shell-extension-desktop-icons fix in comment #28 (needs sponsorship) is more important than gnome-shell. Because fixing the extension removes the root cause and avoids any potential side-effects (more bugs) of letting the extension carry on with the mistake.

[Mathew Hodson (mhodson)]

gnome-shell (3.36.9-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (LP: #1921963):
    - Improve login screen accessibility
    - Prefer image-data hint over app-icon in notifications
    - Plugged leak
    - Fixed crashes
  * debian/patches:
    - Correctly handle login cancellation and failures (LP: #1915066)
    - Show errors on fingerprint failures and limit retries (LP: #1865838)
    - gdm: Don't try to retry authenticating when the service is unavailable
      (LP: #1915570)
    - Enable to use Escape to cancel auth requests (with limits) (LP: #1921929)

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 31 Mar 2021 00:50:16 +0200

[Brian Murray (brian-murray)]

I sponsored the patch in comment #28 after updating the changelog as some new versions of that package came out.

[Brian Murray (brian-murray)]

 $ dput gnome-shell-extension-desktop-icons_20.04.0-3\~ubuntu20.04.4_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /tmp/pkgs/focal/gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4_source.changes: Valid signature from 1E918B66765B3E31
Checking signature on .dsc
gpg: /tmp/pkgs/focal/gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4.dsc: Valid signature from 1E918B66765B3E31
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4.dsc: done.
  Uploading gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4.debian.tar.xz: done.
  Uploading gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4_source.buildinfo: done.
  Uploading gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.4_source.changes: done.
Successfully uploaded packages.

[Daniel van Vugt (vanvugt)]

Thanks! That one was waiting for sponsorship almost nine months.

[Robie Basak (racb)]

Hello Peter, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/20.04.0-3~ubuntu20.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Daniel van Vugt (vanvugt)]

Verified fixed on focal with gnome-shell-extension-desktop-icons 20.04.0-3~ubuntu20.04.4 using the test case at the top of this bug.

Although I expect the test case should not trigger the bug anymore at all after gnome-shell 3.36.9, it's nice to have the root cause also fixed in gnome-shell-extension-desktop-icons.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0-3~ubuntu20.04.4

---------------
gnome-shell-extension-desktop-icons (20.04.0-3~ubuntu20.04.4) focal; urgency=medium

  * Add desktopManager-Avoid-scheduling-multiple-_layoutChil.patch to
    fix crashes in st_bin_destroy (LP: #1898005)

 -- Brian Murray <email address hidden> Thu, 14 Oct 2021 13:20:13 -0700

[Bin Li (binli)]

@vanvugt,

 I checked the latest source code of gnome-shell-extension-desktop-icons, found the desktopManager-Avoid-scheduling-multiple-_layoutChil.patch was not applied, there are not this file in debian/patches/series.

[Daniel van Vugt (vanvugt)]

You appear to be right :(

My patch in comment #28 is correct, but the one we actually released is not:

https://launchpadlibrarian.net/563648801/gnome-shell-extension-desktop-icons_20.04.0-3~ubuntu20.04.3_20.04.0-3~ubuntu20.04.4.diff.gz

[Daniel van Vugt (vanvugt)]

I proposed a fixup here: https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-desktop-icons/-/merge_requests/11

Best to start with git.

[Daniel van Vugt (vanvugt)]

As mentioned in comment #37, the original test case is likely to pass in 3.36.9+ even without the patch correctly applied. So the new second test case should be to verify that the patch is correctly applied.

[Gunnar Hjalmarsson (gunnarhj)]

Correction of gnome-shell-extension-desktop-icons uploaded to focal unapproved queue.

[Steve Langasek (vorlon)]

So the upload in the focal queue:
- adds a debian/patches/series entry
- for a patch that was already included in the previous upload
- that was released because the test case in the bug description was reported to have passed with the version in -proposed

And there have been no changes to the test case.

What is this upload actually fixing?

[Daniel van Vugt (vanvugt)]

Steve,

IIRC this crash was fixed by *either* the gnome-shell or extension fix. So the original test case would fail only while *neither* of the two fixes were applied.

The gnome-shell fix made the shell API more robust so as to protect itself from crashing in the presence of a buggy extension.

The gnome-shell-extension-desktop-icons fix corrects the buggy extension. This is still worthwhile because it fixes a sudden and unnecessary spike of memory and CPU usage from unthrottled timer duplication. That IIRC could still cause instability in the extension/shell based on my memory of testing a year ago. However I've tried stress testing both with and without the fix on focal today and can't see any practical difference in performance. Only technically we shouldn't declare the fix as "released" until the series file is corrected to apply the patch.

[Brian Murray (brian-murray)]

Hello Peter, or anyone else affected,

Accepted gnome-shell-extension-desktop-icons into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons/20.04.0-3~ubuntu20.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Gunnar Hjalmarsson (gunnarhj)]

From the buildlog:

dpkg-source: info: applying desktopManager-Avoid-scheduling-multiple-_layoutChil.patch

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons - 20.04.0-3~ubuntu20.04.5

---------------
gnome-shell-extension-desktop-icons (20.04.0-3~ubuntu20.04.5) focal; urgency=medium

  [ Daniel van Vugt ]
  * Really apply the patch added in 20.04.0-3~ubuntu20.04.4
    (LP: #1898005)

 -- Gunnar Hjalmarsson <email address hidden> Fri, 05 Nov 2021 13:37:32 +0100