Authentication is cancelled (and immediately restarted) hitting Escape causing fingerprint to stop working and multiple stale gdm working

[Marco Trevisan (Treviño)]

[ Test case ]

In the user session lockscreen (gdm login screen is fine):

- Lock the screen
- Hit Enter
- Hit Escape
- Repeat

Checking watch -n1 "ps aux |grep gdm-session-worker" (or just ps'ing after unlocked) gdm workers should not be running (a part the one used for logging in).

Fingerprint unlocking is particularly hit by this as the service may prevent further authentication to happen until the PAM module times out.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3654

[ Regression potential ]

Authenticating at login screen or at unlock screen stops working after wrong credentials have been used once or the request has been cancelled via escape key.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.3-2ubuntu1

---------------
gnome-shell (3.38.3-2ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1915089)
  * debian/patches: Correctly handle login cancellation and failures.
    Ensure the GDM workers are terminated before restarting a new auth
    request, allowing fingerprint authentication to be restarted.
    (LP: #1915066)
  * debian/patches: Show errors on fingerprint failures and limit retries.
    (LP: #1865838)
  * debian/control: BD on gstreamer and pipewire, depend on gstreamer1.0-pipewire.
    Enable building with pipewire now that is in main and add runtime
    dependency on gstreamer-pipewire to gnome-shell (LP: #1901391).

gnome-shell (3.38.3-2) unstable; urgency=medium

  * Team upload
  * d/patches: Update to 3.38.3-3-ge3dc4401d from gnome-3-38 branch
    - Fix opening Extensions app from notification
    - Fix workspace layout in right-to-left locales
    - Don't break window focusing if trying to take an area screenshot while
      an application such as a game has an X11 grab (LP: #1910235)

gnome-shell (3.38.3-1) unstable; urgency=medium

  * Team upload
  * d/watch: Only watch for 3.38.x versions
  * New upstream release

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 09 Feb 2021 05:16:10 +0100

[Brian Murray (brian-murray)]

Hello Marco, or anyone else affected,

Accepted gnome-shell into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.38.3-2ubuntu0.20.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Marco, or anyone else affected,

Accepted gnome-shell into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.36.9-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted gnome-shell (3.36.9-0ubuntu0.20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.6 (ppc64el, amd64, armhf, s390x, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#gnome-shell

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Marco Trevisan (Treviño) (3v1n0)]

❯ apt-cache policy gnome-shell
gnome-shell:
  Installato: 3.36.9-0ubuntu0.20.04.1
  Candidato: 3.36.9-0ubuntu0.20.04.1
  Tabella versione:
 *** 3.36.9-0ubuntu0.20.04.1 400
        400 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages

Only one worker is running as expected (after various relogin cycles)

ps aux |grep gdm-session-worker
root 9195 0.0 0.0 312484 9700 ? Sl mag27 0:00 gdm-session-worker [pam/gdm-password]

[Marco Trevisan (Treviño) (3v1n0)]

$ apt-cache policy gnome-shell
gnome-shell:
  Installed: 3.38.3-2ubuntu0.20.10.2
  Candidate: 3.38.3-2ubuntu0.20.10.2
  Version table:
 *** 3.38.3-2ubuntu0.20.10.2 500
        500 http://us.archive.ubuntu.com/ubuntu groovy-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.38.2-1ubuntu1~20.10.1 500
        500 http://us.archive.ubuntu.com/ubuntu groovy-updates/main amd64 Packages
     3.38.1-1ubuntu1 500
        500 http://us.archive.ubuntu.com/ubuntu groovy/main amd64 Packages

$ ps aux |grep gdm-session-worker
root 4722 0.0 0.2 324448 10188 ? Sl 12:22 0:00 gdm-session-worker [pam/gdm-password]

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.36.9-0ubuntu0.20.04.1

---------------
gnome-shell (3.36.9-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (LP: #1921963):
    - Improve login screen accessibility
    - Prefer image-data hint over app-icon in notifications
    - Plugged leak
    - Fixed crashes
  * debian/patches:
    - Correctly handle login cancellation and failures (LP: #1915066)
    - Show errors on fingerprint failures and limit retries (LP: #1865838)
    - gdm: Don't try to retry authenticating when the service is unavailable
      (LP: #1915570)
    - Enable to use Escape to cancel auth requests (with limits) (LP: #1921929)

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 31 Mar 2021 00:50:16 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.3-2ubuntu0.20.10.2

---------------
gnome-shell (3.38.3-2ubuntu0.20.10.2) groovy; urgency=medium

  * d/p/gdm-Don-t-try-to-retry-authenticating-when-the-service-is.patch:
    - gdm: Don't try to retry authenticating when the service is unavailable
      (Related to lp:1915570, regression in 3.38.3-2ubuntu0.20.10.1)

gnome-shell (3.38.3-2ubuntu0.20.10.1) groovy; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1915089)
  * debian/patches: Correctly handle login cancellation and failures.
    Ensure the GDM workers are terminated before restarting a new auth
    request, allowing fingerprint authentication to be restarted.
    (LP: #1915066)
  * debian/patches: Show errors on fingerprint failures and limit retries.
    (LP: #1865838)

gnome-shell (3.38.3-2) unstable; urgency=medium

  * Team upload
  * d/patches: Update to 3.38.3-3-ge3dc4401d from gnome-3-38 branch
    - Fix opening Extensions app from notification
    - Fix workspace layout in right-to-left locales
    - Don't break window focusing if trying to take an area screenshot while
      an application such as a game has an X11 grab (LP: #1910235)

gnome-shell (3.38.3-1) unstable; urgency=medium

  * Team upload
  * d/watch: Only watch for 3.38.x versions
  * New upstream release

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 16 Feb 2021 05:23:21 +0100