When connecting to wifi with the proposed linux-oem kernel , the system hangs

[Taihsiang Ho]

[SRU Justification]

[Impact]
With currently in eoan-proposed kernel 5.3.0-25.27, or all other kernels with stable patch "net/flow_dissector: add connection tracking dissection" backported, backport-iwlwifi-dkms has not yet get synced with its data structure layout change, and may cause system hang whenever trying to associate with WiFi base stations.

[Fix]
Ubuntu Sauced fix "backport-address-interface-change-in-linux-skbuff.h-.patch" to be backported to Eoan.

[Test Case]
Verified on following kernels:

  backport-iwlwifi, 7906, 4.15.0-1065-oem, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-1066-oem, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-72-generic, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-73-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-1030-oem-osp1, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-1032-oem-osp1, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-37-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-38-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.3.0-18-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.3.0-24-generic, x86_64: installed

[Regression Potential]
Low. This patch corrects call flow as in-tree kernel source does when that stable patch is patched.

[Other Info]
Proposed Eoan SRU package can be found in https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1855825.

========== original bug description ==========

Dell XPS 13 7390 (CID 201906-27119)(connected with a SAL TBT docking device)
Pre-load Ubuntu
kernel: linux-oem 4.15.0-1066.76-oem

[Description]
The system hangs when connecting to wifi

[Steps to Reproduce]
Connect to bg-wifi over the wifi applet of your desktop. Select the SSID and then being prompted for a password. The system hangs immediately after entering the password.

Reproducing Rate: 100%

[Expected Result]
Wifi works and the system keeps running.

[Actual Result]
System hangs.

[Additional Information]
4.15.0-1066 oem kernel looks good for this test case.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: linux-oem 4.15.0.1066.70
ProcVersionSignature: Ubuntu 4.15.0-1065.75-oem 4.15.18
Uname: Linux 4.15.0-1065-oem x86_64
ApportVersion: 2.20.9-0ubuntu7.10
Architecture: amd64
Date: Tue Dec 10 13:47:54 2019
DistributionChannelDescriptor:
 # This is the distribution channel descriptor for the OEM CDs
 # For more information see http://wiki.ubuntu.com/DistributionChannelDescriptor
 canonical-oem-somerville-bionic-amd64-20180608-47+beaver-three-eyed-raven+X92
InstallationDate: Installed on 2019-10-08 (63 days ago)
InstallationMedia: Ubuntu 18.04 "Bionic" - Build amd64 LIVE Binary 20180608-09:38
SourcePackage: linux-meta-oem
UpgradeStatus: No upgrade log present (probably fresh install)

[You-Sheng Yang (vicamo)]

This was also reported on https://gitlab.com/vicamo/backport-iwlwifi-dkms/issues/7, and it has basically the same root cause with bug 1854156.

[You-Sheng Yang (vicamo)]

Please try PPA in https://launchpad.net/~vicamo/+archive/ubuntu/ppa-gitlab-backport-iwlwifi-dkms-7

[You-Sheng Yang (vicamo)]

So far we haven't land backport-iwlwifi-dkms to Bionic/Disco, but it has been included in some OEM platforms.

This is actually a upstream bug.

[You-Sheng Yang (vicamo)]

This is reproducible on all mainline kernels >= 5.3.10, 4.19.83, 4.14.153, 4.9.200, 4.4.200.

For Ubuntu, it means Focal 5.4 kernels, Eoan >= 5.3.0-24, Disco >= 5.0.0-38, Bionic >= 4.15.0-73, OEM >= 4.15.0-1066, OEM-OSP1 >= 5.0.0-1032.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[You-Sheng Yang (vicamo)]

PPA for SRU proposal: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1855825

[You-Sheng Yang (vicamo)]

Verified following kernel/dkms versions with Intel Wireless 9260, linux-firmware 1.173.13:

  backport-iwlwifi, 8042, 4.15.0-1065-oem, x86_64: installed
  backport-iwlwifi, 8042, 4.15.0-1066-oem, x86_64: installed
  backport-iwlwifi, 8042, 4.15.0-72-generic, x86_64: installed
  backport-iwlwifi, 8042, 4.15.0-73-generic, x86_64: installed
  backport-iwlwifi, 8042, 5.0.0-1030-oem-osp1, x86_64: installed
  backport-iwlwifi, 8042, 5.0.0-1032-oem-osp1, x86_64: installed
  backport-iwlwifi, 8042, 5.0.0-37-generic, x86_64: installed
  backport-iwlwifi, 8042, 5.0.0-38-generic, x86_64: installed
  backport-iwlwifi, 8042, 5.3.0-18-generic, x86_64: installed
  backport-iwlwifi, 8042, 5.3.0-24-generic, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-1065-oem, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-1066-oem, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-72-generic, x86_64: installed
  backport-iwlwifi, 7906, 4.15.0-73-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-1030-oem-osp1, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-1032-oem-osp1, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-37-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.0.0-38-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.3.0-18-generic, x86_64: installed
  backport-iwlwifi, 7906, 5.3.0-24-generic, x86_64: installed

This bug, as well as bug 1856024, is no longer reproducible.

[You-Sheng Yang (vicamo)]

Mark Disco as WONTFIX for backport-iwlwifi-dkms has never been included officially, nor in OEM image, so it's not affected anyway.

[You-Sheng Yang (vicamo)]

For comment #12, s/bug 1856024/bug 1855978/.

[You-Sheng Yang (vicamo)]

Upstream bug https://bugzilla.kernel.org/show_bug.cgi?id=205839 .

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 8042-0ubuntu2

---------------
backport-iwlwifi-dkms (8042-0ubuntu2) focal; urgency=low

  * debian/gbp.conf, debian/gitlab-ci.yml
    - update series to focal
  * debian/patches/0006-backport-address-interface-change-in-linux-skbuff.h-.patch
    - Fix system hang on connecting to WiFi base station. (LP: #1855825)

 -- You-Sheng Yang <email address hidden> Wed, 11 Dec 2019 16:20:39 +0800

[You-Sheng Yang (vicamo)]

Since backport-iwlwifi-dkms is not available officially in Ubuntu Archive yet, I'm marking linux/bionic as INVALID here, but still tracking the backport status in bug 1856024.

[Timo Aaltonen (tjaalton)]

Hello Taihsiang, or anyone else affected,

Accepted backport-iwlwifi-dkms into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/7906-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[You-Sheng Yang (vicamo)]

Verified 7906-0ubuntu3/eoan-proposed.

[Lynn (griffin-ld)]

This affects me using hwe-18.04-edge with kernel 5.3.0-24, but not 5.3.0-19.

[You-Sheng Yang (vicamo)]

Hi Lynn,

As already commented in #17, backport-iwlwifi-dkms doesn't exist in Bionic officially yet. No matter where do you install it from, they have been fixed either in released or in proposed channel. We're to land a fixed version of backport-iwlwifi-dkms into Bionic in bug 1856024. No more things to do here.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 7906-0ubuntu3

---------------
backport-iwlwifi-dkms (7906-0ubuntu3) eoan; urgency=critical

  * debian/patches/0006-backport-address-interface-change-in-linux-skbuff.h-.patch
    - Fix system hang on connecting to WiFi base station. (LP: #1855825)

 -- You-Sheng Yang <email address hidden> Wed, 11 Dec 2019 16:20:39 +0800