Cursor displayed incorrectly (looks like incorrect stride)
Bug #1526779 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
kevin gunn | ||
Mir |
Fix Released
|
High
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I've seen this testing the android stack and external displays on mako and on an old VGN-FJ1Z laptop.
The cursor appears and works, but the image is broken into horizontal lines.
Related branches
lp:~alan-griffiths/mir/fix-1526779
- Chris Halse Rogers: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Alberto Aguirre (community): Approve
- Andreas Pokorny (community): Approve
-
Diff: 105 lines (+51/-8)2 files modifiedsrc/platforms/mesa/server/kms/cursor.cpp (+15/-8)
tests/unit-tests/graphics/mesa/kms/test_cursor.cpp (+36/-0)
Changed in mir: | |
status: | New → In Progress |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
Changed in mir: | |
milestone: | none → 0.19.0 |
Changed in mir: | |
importance: | Undecided → High |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → kevin gunn (kgunn72) |
milestone: | none → ww04-2016 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in canonical-devices-system-image: | |
milestone: | ww04-2016 → 9.1 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hacking a bit of debug code into mgm::Cursor: :pad_and_ write_image_ data_locked( ) (on the laptop) suggests something odd:
image_width = 24
image_height = 24
image_stride = 96
buffer_width = 256
buffer_height = 259
buffer_stride = 1024
Hacking the buffer contents shows that the cursor onscreen is actually 60x60 and has a stride of 64.
This is confirmed by hard coding these values into this function, when the cursor appears normally.
As this function isn't part of the android driver, we may have two different bugs here.