[regression] Nested servers can select wrong platform
Bug #1515558 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alan Griffiths | ||
0.18 |
Won't Fix
|
Medium
|
Mir development team | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Nested servers do not have the information required to deduce which platform has been selected by the host server. (The host may be a different user with different permissions, with different environment variables and different command-line options.)
Original scenario:
$ sudo bin/mir_demo_server --window-manager system-compositor --display-config sidebyside --vt 1 --arw-file
$ bin/mir_demo_server --host /tmp/mir_socket --display-config clone
...
[1447325929.742637] mirserver: Selected driver: dummy (version 0.18.0)
Seems to be -c 3098 as specifying a dummy --vt parameter is a workaround
Related branches
lp:~mir-team/mir/revert-3098
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Approve
- Cemil Azizoglu (community): Needs Information
-
Diff: 126 lines (+11/-29)5 files modifiedsrc/platforms/mesa/server/kms/platform_symbols.cpp (+3/-21)
src/platforms/mesa/server/x11/graphics/graphics.cpp (+1/-1)
tests/unit-tests/graphics/mesa/kms/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/mesa/x11/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/test_platform_prober.cpp (+3/-3)
lp:~alan-griffiths/mir/nested-server-uses-host-graphics-platform
- PS Jenkins bot (community): Approve (continuous-integration)
- Brandon Schaefer (community): Approve
- Alberto Aguirre (community): Approve
- Kevin DuBois (community): Approve
- Mir CI Bot: Approve (continuous-integration)
- Alexandros Frantzis (community): Approve
- Cemil Azizoglu (community): Approve
-
Diff: 851 lines (+335/-33)31 files modifiedexamples/basic.c (+12/-0)
include/client/mir_toolkit/client_types.h (+15/-0)
include/client/mir_toolkit/mir_connection.h (+11/-0)
include/common/mir/libname.h (+35/-0)
include/platform/mir/graphics/platform_ipc_package.h (+7/-0)
include/platform/mir/module_properties.h (+7/-1)
src/client/mir_connection.cpp (+26/-0)
src/client/mir_connection.h (+1/-0)
src/client/mir_connection_api.cpp (+14/-0)
src/client/symbols.map (+7/-1)
src/common/CMakeLists.txt (+2/-1)
src/common/libname.cpp (+29/-0)
src/common/symbols.map (+3/-2)
src/platforms/android/server/ipc_operations.cpp (+17/-2)
src/platforms/android/server/platform.cpp (+7/-2)
src/platforms/evdev/platform_factory.cpp (+6/-2)
src/platforms/mesa/server/common/ipc_operations.cpp (+12/-1)
src/platforms/mesa/server/kms/platform_symbols.cpp (+7/-2)
src/platforms/mesa/server/x11/graphics/graphics.cpp (+9/-3)
src/platforms/mesa/server/x11/input/input.cpp (+4/-2)
src/protobuf/mir_protobuf.proto (+11/-0)
src/protobuf/symbols.map (+27/-0)
src/server/frontend/session_mediator.cpp (+12/-0)
src/server/graphics/default_configuration.cpp (+16/-10)
src/server/graphics/nested/host_connection.h (+1/-0)
src/server/graphics/nested/mir_client_host_connection.cpp (+14/-0)
src/server/graphics/nested/mir_client_host_connection.h (+1/-0)
tests/include/mir/test/doubles/stub_host_connection.h (+2/-0)
tests/mir_test_framework/platform_graphics_dummy.cpp (+2/-1)
tests/mir_test_framework/stub_input.cpp (+5/-2)
tests/mir_test_framework/stubbed_graphics_platform.cpp (+13/-1)
Changed in mir: | |
importance: | High → Medium |
tags: | added: nested |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir: | |
status: | Fix Released → Fix Committed |
Changed in mir: | |
status: | Triaged → In Progress |
assignee: | Mir development team (mir-team) → Alan Griffiths (alan-griffiths) |
summary: |
- [regression] Nested servers on mesa-kms select wrong (dummy) guest - platform + [regression] Nested servers can select wrong platform |
description: | updated |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yes, reverting -c 3098 fixes the problem