mir::input::Surface::consume(MirEvent const& event) should not take a reference to an opaque type
Bug #1450797 reported by
Alan Griffiths
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
MirEvent has been made opaque in the public API and all use of it in user code should be by way of the mir_event_
As we are publishing include/
This avoids clients (and our own tests) needing hacks like this:
MOCK_
void consume(MirEvent const& event) override { consume(&event); }
Related branches
lp:~alan-griffiths/mir/fix-1450797
- Daniel van Vugt: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Kevin DuBois (community): Approve
-
Diff: 159 lines (+14/-14)12 files modifiedinclude/server/mir/input/surface.h (+1/-1)
include/test/mir/test/doubles/stub_surface.h (+1/-1)
src/server/input/surface_input_dispatcher.cpp (+1/-1)
src/server/scene/basic_surface.cpp (+2/-2)
src/server/scene/basic_surface.h (+1/-1)
tests/acceptance-tests/test_client_input.cpp (+1/-1)
tests/include/mir/test/doubles/mock_input_surface.h (+1/-1)
tests/include/mir/test/doubles/mock_surface.h (+1/-1)
tests/include/mir/test/doubles/stub_scene_surface.h (+1/-1)
tests/mir_test_framework/stub_surface.cpp (+1/-1)
tests/unit-tests/scene/test_basic_surface.cpp (+1/-1)
tests/unit-tests/scene/test_surface.cpp (+2/-2)
Changed in mir: | |
importance: | Undecided → Low |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
status: | New → In Progress |
milestone: | none → 0.19.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.19.0