Crash due to fd leak when playing sounds in pidgin
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pidgin (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Wily |
Fix Released
|
High
|
Unassigned |
Bug Description
The Ubuntu Error Tracker has been receiving reports about a problem regarding pidgin. This problem was most recently seen with version 1:2.10.11-0ubuntu4, the problem page at https:/
Upstream bug: https:/
Partial backtrace:
#0 0x00007f0e72819b24 in g_source_attach (source=
#1 0x00007f0e74b848b8 in gst_bus_
#2 0x00007f0e74b849e0 in gst_bus_
#3 0x000056004c7cfb3a in pidgin_
at /build/
#4 0x000056004c7cf927 in pidgin_
at /build/
[Impact]
* Each sound played will leak a file descriptor.
* Crash (null pointer dereference) after playing sounds roughly 1000 times (depending on fd limit)
* Depending on the amount of activity, this can mean every few hours for some users (it's once for each received or sent message)
[Test Case]
1. Set the file descriptor limit low enough to be able to login, plus a few extra. "ulimit -Sn 20" works for me
2. Start pidgin
3. Tools menu -> preferences -> sounds tab
4. Click "preview" 10 times or so
5. Acquire crash
[Regression Potential]
* The fix consists in adding two lines, returning FALSE when a sound finishes playing or when an error happens, which tells gstreamer to free those file descriptors, so it's highly unlikely that this could make things worse.
* A user who reported this bug yesterday was given a .deb file with the fix, who also distributed that fixed .deb to other 50 users who also had the issue in ubuntu wily. Everyone is happy now.
[Other Info]
* This fix will be included in pidgin 2.10.12, set to release very soon.
* The bug originally happened because of the backported gstreamer 1.0 patch that was also introduced in post-2.10.11 development versions.
Changed in pidgin (Ubuntu): | |
importance: | Undecided → High |
Changed in pidgin (Ubuntu): | |
status: | Confirmed → Fix Released |
Fix from https:/ /hg.pidgin. im/pidgin/ main/rev/ 902b1fd334bd