performing action on menu incorrectly clears and reloads menu

Bug #1217676 reported by Bill Filler
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
telephony-service
Fix Released
Undecided
Gustavo Pichorim Boiko
indicator-messages (Ubuntu)
Invalid
High
Lars Karlitski
unity8 (Ubuntu)
Fix Released
High
Nick Dedekind

Bug Description

touch image 082713
indicator-messages 13.10.1+13.10.20130822.5-0ubuntu1

On touch, if you delete a message from the menu or reply to a text message, the entire menu is cleared out (all items removed) and then re-added. This is not the desired behavior and is a regression. Items should be removed but other items in the list should not be removed and rea-dded.

Steps to reproduce:
1) make multiple incoming calls or text messages to the phone (or populate it programatically)
2) swipe to delete a message or reply to a text message

Expected Results:
- the acted upon item should be removed from the list and all other items should not change

Actual Results:
- the acted upon items is removed but so are all the other items, then they are reloaded. this looks bad.

Related branches

Bill Filler (bfiller)
Changed in unity8 (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
importance: Undecided → High
Changed in indicator-messages (Ubuntu):
assignee: nobody → Lars Uebernickel (larsu)
importance: Undecided → High
Revision history for this message
Lars Karlitski (larsu) wrote :

I cannot reproduce this, but I wasn't able to try this out with the phone app.

How does the script you're using work? Does it send messages to the messaging menu directly or does it insert them into telepathy? Could you please attach it?

Changed in indicator-messages (Ubuntu):
status: New → Incomplete
Revision history for this message
Lars Karlitski (larsu) wrote :

Just talked to Gustavo on IRC, he confirmed it is a bug in telephony-service.

Changed in indicator-messages (Ubuntu):
status: Incomplete → Invalid
Changed in unity8 (Ubuntu):
status: New → Invalid
Changed in telephony-service:
assignee: nobody → Gustavo Pichorim Boiko (boiko)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

This problem was fixed some time ago when we splitted the UI from the code that actually handles the telepathy channels.

Changed in telephony-service:
status: New → Fix Released
Revision history for this message
Bill Filler (bfiller) wrote :

There was some confusion and this bug has nothing to do with the telephony-service. I've attached a script (and a link for an MR to indicators-client) that simply populates the messaging menu using the python api. You can then try to remove items from the list by swiping to delete or replying (just fake) and you'll see the problem.

To run the script:
1) adb push chewie_messaging_populate_menu /home/phablet
2) ssh into device as user phablet
3) sudo apt-get install gir1.2-messagingmenu-1.0
4) run the script (as phablet user)
./chewie_messaging_populate_menu

This will populate the messaging menu with lots of sample data.

Changed in indicator-messages (Ubuntu):
status: Invalid → Confirmed
Changed in unity8 (Ubuntu):
status: Invalid → Confirmed
Revision history for this message
Bill Filler (bfiller) wrote :
Revision history for this message
Bill Filler (bfiller) wrote :

fyi, associated MR to update the script in indicators-client is here:
https://code.launchpad.net/~bfiller/indicators-client/populate-messaging-menu-example/+merge/183275

Revision history for this message
Lars Karlitski (larsu) wrote :

Thanks Bill, I was able to reproduce it with that script and could also confirm that it is a bug in unity8 caused by qmenumodel. Nick's branch that ports the messaging indicator to unitymenumodel fixes this issue.

Changed in indicator-messages (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 7.81.3+13.10.20130927.3-0ubuntu1

---------------
unity8 (7.81.3+13.10.20130927.3-0ubuntu1) saucy; urgency=low

  [ Michal Hruby ]
  * Correctly handle image URI scheme in results.

  [ Michał Sawicz ]
  * Make SHOW_DASH and HIDE_DASH close the current preview. (LP:
    #1231404)
  * Add a LazyImage component that shows an activity spinner for long-
    loading images and handles aspect ratio properly.
  * Fix Qt 5.1 FTBFS and suppress some build warnings.

  [ Albert Astals ]
  * Make sure we always have least have one column in the gridview. (LP:
    #1225391)
  * LVWPH: Make sure we always overshoot vertically. (LP: #1229851)
  * Remember the expanded categoryId and not the expanded index The
    index can change on search, and we still want to maintain it
    expanded in that case. (LP: #1230216)
  * Fix showHeader in an edge case of notShownByItsOwn Not all the tests
    i've added fail without the code fix, but i've added them just to be
    more covered . (LP: #1230187)

  [ Diego Sarmentero ]
  * Handling error signal from the DownloadTracker plugin (BUG:
    #1229744). (LP: #1229744)
  * Remove "Reviews and Comments" section from Application Preview until
    the feature is ready (BUG: #1226632) - Detect when the keyboard is
    being shown to allow the user to scroll the Preview even more if
    necessary to interact with the components at the bottom of that
    preview, and don't leave those components obscured behind the
    keyboard (BUG: #1226638). (LP: #1226632, #1224717, #1226638)

  [ Nick Dedekind ]
  * Brought messaging indicator inline with UnityMenuModel &
    UnityMenuAction. (LP: #1217676, #1217678)

  [ Pawel Stolowski ]
  * Support canned search queries returned by Home Scope.
  * Cancel previous actions and previews on new activation / preview.
    Expose previewed data row in Preview object.

  [ Michael Terry ]
  * Only enable the Bottombar when the HUD is available. (LP: #1220306)
  * Increase the "Skip intro" clickable area, making dismissing the edge
    demo intro feel more natural. (LP: #1220632)

  [ Michael Zanetti ]
  * drop our CrossFadeImage in favor of the SDK one. (LP: #1227783)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 358
 -- Ubuntu daily release <email address hidden> Fri, 27 Sep 2013 14:13:22 +0000

Changed in unity8 (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.