[UIFe] Add legal notice buttons to UI

[David King]

The online accounts settings panel stores credentials and access tokens for online services locally, and shows service provider icons to associate a local account with a provider. This presents some problems when complying with the terms of service of the online providers, as most require that it is clear that services are not misrepresented as being recommended by the provider in question, especially with the use of provider logos. To comply with the terms of service, it must be made clear what the scope of the application (Online Accounts) is and how the user's data is used.

To fix this, in consultation with Canonical legal counsel and design, I have added a legal notice to the Mallard help of the Online Accounts control centre panel. The notice briefly explains what the Online Accounts technology does with the user's information and some other legal details. I have linked this help page to the panel UI with two new link buttons, one shown during authorization and the other shown during configuration, so that the user can access the legal notice from the UI at all times.

The relevant UI changes are the addition of two user-visible strings (‘Learn more’ and ‘Legal notice’ for the link buttons), the change of an existing string (adds a full stop at the end of a sentence) and the addition of the legal notice as a Mallard page (a page of legal copy). The additions result in the UI of the panel changing to accommodate the new buttons, such that any existing screenshots would need to be retaken. I will attach screenshots to demonstrate the UI changes.

The merged changes which are included in this UI freeze exception request are:

https://code.launchpad.net/~amigadave/online-accounts-gnome-control-center/legal-notice/+merge/126387

[David King (amigadave)]

Link to my email request to the ubuntu-translators list:

https://lists.ubuntu.com/archives/ubuntu-translators/2012-September/005640.html

Link to my email request to the ubuntu-doc list:

https://lists.ubuntu.com/archives/ubuntu-doc/2012-September/016923.html

[Iain Lane (laney)]

Why do you use different text in the two locations and put the link in different places? Wouldn't consistency be good here?

[David King (amigadave)]

Hi Iain, I agree that it seems inconsistent. I have subscribed Calum Pringle, the designer involved, so that he can comment.

[Calum Pringle (calumpringle)]

Having consulted legal, the terminology difference was because of the difference in context

1. the user is just looking at Online Accounts, legal notice doesn't necessarily apply to what they are intending to do
2. the user is actually being asked for their personal details, and wants to know what is being done with them.

To maintain consistency with other settings panels the "Legal Notice" should be placed top right of the online accounts panel

To minimise additional UI elements, "Learn more" has been added within the context of the copy text explanation during account verification.

[Iain Lane (laney)]

OK I don't mind so much about having two different strings. Translators might feel differently, however.

But I don't see what we're trying to be consistent with by having "Legal Notice" top right like that. The only other panel I have installed here that does anything similar is the "Color" one, and that already has some text up there so it doesn't look /so/ bad. Otherwise, there isn't really so much consistency between panels that I can discern. Really I'd prefer the link to be inline in both cases.

Seems like mardy agrees that it doesn't look very good on the review[0], and Dave in comment #7 here. Any chance you could reconsider?

[0] https://code.launchpad.net/~amigadave/online-accounts-gnome-control-center/legal-notice/+merge/126387/comments/271997

[Iain Lane (laney)]

I like that much more, thanks!

[Jeremy Bícha (jbicha)]

+1 from the Documentation Team. We won't need to change docs for this.

The theme you're using is a little confusing (because it's different than what my computer looks like), but adding the Legal notice to the bottom is fine. I agree with Laney that I like it better than on the top.

[Adolfo Jayme Barrientos (fitojb)]

As a translator I give my +1, it's just one string and it's pretty important stuff (legal)

[Scott Kitterman (kitterman)]

UIFe approved then. It does look to me like removing the period in lines 22/23 of the diff is unrelated to this change. Please drop that from the proposed change before uploading it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center-signon - 0.0.18-0ubuntu1

---------------
gnome-control-center-signon (0.0.18-0ubuntu1) quantal; urgency=low

  * New upstream release.
    - [UIFe] Add legal notice buttons to UI (LP: #1056718)
  * debian/patches/revert_string_change.patch
    - revert dropping of a period unrelated to the above UIFe
 -- Ken VanDine <email address hidden> Fri, 28 Sep 2012 16:56:22 -0400

[Adolfo Jayme Barrientos (fitojb)]

* debian/patches/revert_string_change.patch
    - revert dropping of a period unrelated to the above UIFe

This patch was incorrect, a new string has appeared with the patch. Too late anyway, I have translated it too...