Comment 32 for bug 536076

Revision history for this message
Sigra (sigra) wrote :

> To avoid similar problems happening with playercolor files, I would prefer to keep the flag. (In fact, given the above, it would make sense to *add* an additional key/value pair indicating the number of frames in an animation. Or to radically change the way the file loading works. Oh well.)

The radical change sounds much more sensible than keeping this kludge and adding another one. Keeping things simple is a good idea. The designer should just have to put the files there and it should Just Work.

With the playercolor key, the code must check that there are indeed no _pc-files when it is false, to make sure that the designer knows that he forgot to set the value to true after adding the files. (Similarly with the number-of-frames key, the code must check that there are no extra frames that the designer might have tried to add, but he forgot to change the value. But maybe this issue would go away with MNG.)

(As usual, providing the same information in different ways requires extra error checking code to make sure that the information is actually synchronized.)

This filesystem code, known to be somewhere between semi-broken and half-working, continues to cause confusion...