Shipnames mismatch in multiplayer
Bug #1800338 reported by
Toni Förster
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Multiplayer seafaring maps desync because the name of the first ship build is different on every client:
Client 1:
MO(17845,
Client 2:
MO(17845,
Part of this bugreport:
https:/
https:/
Related branches
lp:~widelands-dev/widelands/terrain_affinity_as_int
- Arty: Approve
-
Diff: 1945 lines (+397/-389)43 files modifieddata/tribes/immovables/berry_bushes/blueberry/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/currant_black/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/currant_red/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/desert_hackberry/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/juniper/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/raspberry/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/sea_buckthorn/init.lua (+3/-3)
data/tribes/immovables/berry_bushes/strawberry/init.lua (+3/-3)
data/world/immovables/bush1/init.lua (+8/-8)
data/world/immovables/trees/alder/init.lua (+8/-8)
data/world/immovables/trees/aspen/init.lua (+3/-3)
data/world/immovables/trees/beech/init.lua (+3/-3)
data/world/immovables/trees/birch/init.lua (+3/-3)
data/world/immovables/trees/cirrus/init.lua (+3/-3)
data/world/immovables/trees/larch/init.lua (+3/-3)
data/world/immovables/trees/liana/init.lua (+3/-3)
data/world/immovables/trees/maple/init.lua (+3/-3)
data/world/immovables/trees/mushroom_dark/init.lua (+3/-3)
data/world/immovables/trees/mushroom_green/init.lua (+3/-3)
data/world/immovables/trees/mushroom_red/init.lua (+3/-3)
data/world/immovables/trees/oak/init.lua (+3/-3)
data/world/immovables/trees/palm_borassus/init.lua (+3/-3)
data/world/immovables/trees/palm_coconut/init.lua (+3/-3)
data/world/immovables/trees/palm_date/init.lua (+3/-3)
data/world/immovables/trees/palm_oil/init.lua (+3/-3)
data/world/immovables/trees/palm_roystonea/init.lua (+3/-3)
data/world/immovables/trees/rowan/init.lua (+3/-3)
data/world/immovables/trees/spruce/init.lua (+3/-3)
data/world/immovables/trees/twine/init.lua (+3/-3)
data/world/immovables/trees/umbrella_green/init.lua (+3/-3)
data/world/immovables/trees/umbrella_red/init.lua (+3/-3)
data/world/terrains/init.lua (+145/-145)
src/logic/game.cc (+0/-4)
src/logic/game.h (+0/-3)
src/logic/map_objects/immovable.cc (+3/-3)
src/logic/map_objects/terrain_affinity.cc (+62/-53)
src/logic/map_objects/terrain_affinity.h (+26/-20)
src/logic/map_objects/tribes/worker.cc (+11/-11)
src/logic/map_objects/world/terrain_description.cc (+10/-10)
src/logic/map_objects/world/terrain_description.h (+10/-10)
src/scripting/lua_map.cc (+10/-10)
test/maps/lua_testsuite.wmf/scripting/immovables_descriptions.lua (+9/-9)
test/maps/lua_testsuite.wmf/scripting/terrains_resources_descriptions.lua (+8/-8)
Changed in widelands: | |
milestone: | none → build20-rc1 |
tags: | added: desync multiplayer tribes |
Changed in widelands: | |
assignee: | nobody → GunChleoc (gunchleoc) |
status: | New → In Progress |
Changed in widelands: | |
status: | In Progress → Fix Committed |
assignee: | GunChleoc (gunchleoc) → nobody |
To post a comment you must log in.
Good catch!
pick_shipname() is already using game.logic_rand(), which is the correct random function.
We could try using a new playercommand in EditorGameBase: :create_ ship to see if that helps.