widelands

Editor: Improve texts for resources tool

Bug #1736095 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned
widelands build20-rc1

Bug Description

This is maybe related to Bug 1649706 (setting water on the coast appears to remove fish), but i think it is different:

1. Open a map
2. Put some mountain area in it
3. Open resources menu
4. Choose iron
5. Set tool size '2'
6. Click 4 times on the same spot of mountains so we have resource amount of 4 iron
7. Chose coal resource
8. Set 'Set value' to 4 (the same value as we have set for iron on the map)
9. Press CTRL and click on the same spot where you have set iron

Result: No change of the resources, iron still remains.

This happens at least if: amount of resources on map == amount of 'Set Value'

But i am not sure, because when i encountered this bug the first time, i was sure the values were different.

Same appears with resources fish and water, where fish is directly set on the coast line.

See original description

Related branches

lp:~widelands-dev/widelands/bug_1736095_improve_text_for_resources_height
GunChleoc: Approve
kaputtnik (community): Needs Fixing
Diff: 801 lines (+114/-64)
37 files modified
data/campaigns/tutorial01_basic_control.wmf/scripting/texts.lua (+1/-1)
data/campaigns/tutorial04_economy.wmf/scripting/texts.lua (+3/-3)
src/editor/editorinteractive.cc (+7/-7)
src/editor/ui_menus/main_menu_load_map.cc (+1/-1)
src/editor/ui_menus/main_menu_map_options.cc (+1/-1)
src/editor/ui_menus/main_menu_random_map.cc (+1/-1)
src/editor/ui_menus/main_menu_save_map.cc (+1/-1)
src/editor/ui_menus/tool_change_height_options_menu.cc (+2/-2)
src/editor/ui_menus/tool_change_resources_options_menu.cc (+7/-7)
src/editor/ui_menus/tool_noise_height_options_menu.cc (+5/-5)
src/logic/replay_game_controller.cc (+1/-1)
src/ui_basic/button.h (+6/-0)
src/ui_basic/checkbox.h (+5/-0)
src/ui_basic/dropdown.h (+4/-0)
src/ui_basic/editbox.h (+2/-0)
src/ui_basic/listselect.h (+6/-0)
src/ui_basic/messagebox.h (+2/-0)
src/ui_basic/multilineeditbox.h (+2/-0)
src/ui_basic/radiobutton.h (+3/-0)
src/ui_basic/slider.h (+3/-0)
src/ui_basic/spinbox.h (+3/-0)
src/ui_basic/table.h (+7/-2)
src/ui_basic/tabpanel.h (+11/-3)
src/ui_basic/window.h (+1/-0)
src/ui_fsmenu/internet_lobby.cc (+1/-1)
src/ui_fsmenu/launch_mpg.cc (+1/-1)
src/ui_fsmenu/options.cc (+4/-4)
src/wlapplication.cc (+1/-1)
src/wui/building_statistics_menu.cc (+3/-3)
src/wui/game_options_sound_menu.cc (+4/-4)
src/wui/game_statistics_menu.cc (+3/-3)
src/wui/interactive_player.cc (+3/-3)
src/wui/interactive_spectator.cc (+4/-4)
src/wui/load_or_save_game.cc (+1/-1)
src/wui/shipwindow.cc (+1/-1)
src/wui/soldierlist.cc (+2/-2)
src/wui/ware_statistics_menu.cc (+1/-1)
kaputtnik (franku)
description: updated
Revision history for this message
kaputtnik (franku) wrote :

The bug cant be reproduced all the time, or i didn't used the settings which causes it.

description: updated
summary: - Editor: Set Resources with CTRL removes already set resources
+ Editor: Set Resources with CTRL didn't remove already set resources
kaputtnik (franku)
description: updated
Revision history for this message
kaputtnik (franku) wrote : Re: Editor: Set Resources with CTRL didn't remove already set resources

Found a way to reproduce and what the bug is.

Is it intendet that 'Set Resources' removes already set resources? If so it should be clarified imho. e.g. in the tooltip: "CTRL + Click to (re)set the amount of selected resources".

Revision history for this message
GunChleoc (gunchleoc) wrote :

"Ctrl + Click on the map to set the amount of the selected resource", and the label says "Set value" - isn't that explicit enough?

How about:

"Ctrl + Click on the map to change the amount of the selected resource to the selected value",

It's the exact same behaviour as for set terrain height.

tags: added: editor
Revision history for this message
kaputtnik (franku) wrote :

I had always problems to understand the behavior of "Set value" :-S Maybe because we have the abstract term "Value" here... What about:

Resources tool:
Label 1: "Increase/Decrease amount by:"
Tooltip 1: ok, already uses the term "amount"
Label 2: "Set amount to:"
Tooltip 2: Just add a sentence: "CTRL + Click on the map to set the amount of selected resources. This replaces already set resources."

Height tool:
Label 1: "Increase/Decrease the Height by:"
Tooltip 1: already ok
Label 2: "Set Height to:"
Tooltip 2: ok

Revision history for this message
GunChleoc (gunchleoc) wrote :

+1 to #4

tags: added: lowhangingfruit
Changed in widelands:
milestone: none → build20-rc1
status: New → Confirmed
summary: - Editor: Set Resources with CTRL didn't remove already set resources
+ Editor: Improve texts for resources tool
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
Revision history for this message
GunChleoc (gunchleoc) wrote :

We have found out what the actual bug is and filed it as https://bugs.launchpad.net/widelands/+bug/1738641

The relabelling has been done.

Changed in widelands:
status: In Progress → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.