Resources can be replaced only once in editor

Bug #1738641 reported by GunChleoc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned

Bug Description

1. Place some coal
2. Choose Iron
3. Hold CTRL and replacing the coal with iron works
4. Choose Gold
5. Hold down CTRL and try to replace Iron with Gold. This does not work.

Tags: editor

Related branches

Revision history for this message
kaputtnik (franku) wrote :

The problem is not replacing twice. Its just a comparison when amounts of resources are equal.

IMHO ;)

GunChleoc (gunchleoc)
Changed in widelands:
status: New → Fix Committed
Revision history for this message
3plus4i (tobi-heinz) wrote :

Are you actually sure that we really want to change this? As far as I know, the old behavior was meant to prevent accidentally replacing a resource while placing another one. If you actually wanted to replace it you first had to remove the old one manually, just like with immovables, where you can't just "draw" one over another. I found that pretty useful.

Revision history for this message
GunChleoc (gunchleoc) wrote :

Good point - I didn't think of that. I'm reopening this bug for discussion.

Changed in widelands:
status: Fix Committed → Confirmed
Revision history for this message
kaputtnik (franku) wrote :

This change affects only the mode when using "Set Resource" not when using "Place Resource". "Set Resource" has confused me a lot, because sometimes it replaces already set resources and sometimes not. The functionality was unclear.

Together with a changed Tooltip saying "Ctrl + Click on the map to set the amount of the selected resource. This will replace already set resources." the functionality is pretty clear.

Using "Place Resource" acts like before.

Revision history for this message
3plus4i (tobi-heinz) wrote :

I've checked it now in detail and of course you're right. Placing resources normally still doesn't touch existing ones and "setting" them (ctrl + click) was already replacing before this change, unless the amount of existing resources was higher or equal, right? Then the change makes perfect sense since the behavior is consistent now.

Revision history for this message
kaputtnik (franku) wrote :

> (ctrl + click) was already replacing before this change, unless the amount of existing resources was higher or equal, right?

Replacing was not done when one wants to set the exact amount of resource the node on map already contained.

Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

I'll set this bug back to "Fix Committed". Thanks for having another look :)

Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.