Confirming Dismantle building opens dismantle site window

[kaputtnik]

Don't know which revision introduced this or if it was intended:

If a building wants to be dismantled, the window 'Dismantle site' pops up after confirming dismantling of the same building.

I think this behavior has no advantage.

[GunChleoc (gunchleoc)]

The change was introduced in r8308. We can easily get rid of it again if it's annoying.

[kaputtnik (franku)]

Yesterday i played a bit and found this very annoying: To get some soldiers back i dismantled a lot of buildings and every time the 'dismantle site" window pops up. This means additional clicks to through away a window which was not intended to be opened.

I see also no reason what benefit this window has in a situation where i explicitly confirm dismantling. The only reason for having this window is in my opinion: If a ware is missing to build a building and the only solution is to get that ware by dismantling another building. In this case it may be nice to see when that ware will be back again to the economy and if this ware is transported to the building which needs it.

Sorry that i didn't mentioned this in the merge proposal of r8303.

[Notabilis (notabilis27)]

The change was intended and requested by me while reviewing the merged branch. My arguments why I wanted this change:
- Consistency with the behavior of other dialogs. The construction and enhance* dialogs also stay open. That is, they are opened when construction/enhancing starts and open the matching building dialog when done.
- When dismantling a building for its building space it is useful to know when its done (okay, a weak argument).
- The window can be closed with a right click so (in my opinion) it is no big problem when not needed.

To change this back: The relevant changes when adding it were:
https://bazaar.launchpad.net/~widelands-dev/widelands/notifications_buildingwindows/revision/8153/src/logic/player.cc

* I also take the blame for opening the "currently enhancing" window. ;-)

[GunChleoc (gunchleoc)]

I think the enhancing window is fine, because the chance is higher that the user is interested in fiddling with the building's settings once it's done.

[kaputtnik (franku)]

What Gun said, for some windows it's fine. But i don't see a reason why a window should open which has not really any information. Ok, get informed when the dismantling is done could be interesting if one wants to build another building on this spot. How often does this happen?

Closing the window is easily done by a mouseclick, that's true. I played some hours with this and i find it very disturbing to always make an additional right click because this window covers some part of the map.

It's just my opinion, but i bet most other players find this disturbing too... Maybe we should ask Hasi50 for his opinion.

[ypopezios (ypopezios)]

I'm not sure that I understand the intended behaviours. But for what it's worth, I would certainly like to be informed when something gets completed, so as to give my next command (even better, I would like queuing commands, but that's too advanced for now). In my opinion, that's a much stronger argument than avoiding a right click.

[GunChleoc (gunchleoc)]

Most of the time, when you have started dismantling a building, you don't need it for further commands. The window sill stays open when building or enhancing.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1