Background colorization should use a different heuristic
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
High
|
Robert Carr | ||
unity (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
NEW ITERATION:
What is currently defective by design is the way unity is put on top of the background windows. It's a simple colored layer placed above stuff, with some nice blur to makes things more readable but it carries all the issues of washing out the resultant color of the dash, making it less crisp and vibrant.
A nice trick is to play with the underlying background windows (the damage area/pixmap taken from Compiz), blend them with colors, and place the resultant below the dash.
The steps are these:
1) Take the underlying pixmap
2) Blend this pixmap with a tweaked average color using OVERLAY operator
3) Blur the pixmap (as we currently do)
4) Put this new obtained pixmap below the dash
5) At this point, the dash could be just a solid dark layer even with a lower opacity
We might tweak the steps further, but the essential bits will remain the same because what will make the big difference is the blending described in step 2, that we are not doing now.
~~~
ORIGINAL BUG (FIXED Cimi):
The background of the BFB, Workspace Switcher, Lens, and Trash launcher icons tiles need to use a higher saturation of the average background colour of the wallpaper.
Currently the colour is not as prominent as shown in the design, compare the attached image "unity_
Desired resolution:
- Increase the colour saturation in the BFB, Workspace Switcher, Lens, and Trash launcher icons
Related branches
- Gord Allott (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedplugins/unityshell/src/BGHash.cpp (+1/-1)
- Marco Trevisan (Treviño): Approve
- Andrea Cimitan (community): Approve
-
Diff: 267 lines (+71/-51)6 files modifiedplugins/unityshell/src/DesktopLauncherIcon.cpp (+0/-12)
plugins/unityshell/src/DesktopLauncherIcon.h (+0/-3)
plugins/unityshell/src/DeviceLauncherIcon.cpp (+0/-10)
plugins/unityshell/src/DeviceLauncherIcon.h (+0/-2)
plugins/unityshell/src/IconRenderer.cpp (+67/-22)
plugins/unityshell/src/Launcher.cpp (+4/-2)
- Robert Carr (community): Approve
- Tim Penhey (community): Approve
- Jay Taoko (community): Approve
-
Diff: 404 lines (+191/-55)5 files modifiedplugins/unityshell/src/BGHash.cpp (+10/-7)
plugins/unityshell/src/Launcher.cpp (+29/-8)
plugins/unityshell/src/OverlayRenderer.cpp (+58/-16)
plugins/unityshell/src/PanelView.cpp (+59/-15)
plugins/unityshell/src/UnityWindowView.cpp (+35/-9)
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
Changed in unity: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in unity: | |
milestone: | none → backlog |
tags: | added: udp |
Changed in ayatana-design: | |
status: | Fix Committed → Triaged |
Changed in unity: | |
assignee: | nobody → Jason Smith (jassmith) |
status: | Confirmed → Fix Committed |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Confirmed |
importance: | Medium → High |
tags: | added: unity3p |
Changed in unity: | |
assignee: | Jason Smith (jassmith) → Andrea Cimitan (cimi) |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
milestone: | 5.2.0 → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
milestone: | 5.2.0 → 5.4.0 |
Changed in unity (Ubuntu): | |
importance: | Medium → High |
Changed in unity: | |
milestone: | 5.4.0 → 5.6.0 |
summary: |
- Launcher - The background of the BFB, Workspace Switcher, Lens, and - Trash launcher icons tiles need to use a higher saturation of the - average background colour of the wallpaper + Background colorization should use a different heuristic |
description: | updated |
description: | updated |
Changed in ayatana-design: | |
status: | Fix Committed → In Progress |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
description: | updated |
tags: | added: top5p |
Changed in ayatana-design: | |
importance: | High → Critical |
Changed in unity: | |
assignee: | Gord Allott (gordallott) → Robert Carr (robertcarr) |
Changed in unity: | |
milestone: | 5.6.0 → 5.8.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
status: | In Progress → Fix Released |
status: | Fix Released → Fix Committed |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignp removed: udo udp |
Status changed to 'Confirmed' because the bug affects multiple users.