unity::TimeUtil::TimeDelta returns an int value which overflows after 24 days of uptime
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Brandon Schaefer | ||
4.0 |
Won't Fix
|
High
|
Brandon Schaefer | ||
5.0 |
Fix Released
|
High
|
Brandon Schaefer | ||
6.0 |
Fix Released
|
High
|
Brandon Schaefer | ||
unity (Ubuntu) |
Fix Released
|
High
|
Brandon Schaefer | ||
Precise |
Fix Released
|
High
|
Chris J Arges | ||
Quantal |
Fix Released
|
High
|
Timo Jyrinki |
Bug Description
[Impact]
Icons disappearing after int32 delta time variable overflows in 24 days.
[Test Case]
Run the automated test to simulate what happens after to the timedelta ~24 days of Unity running.
[Regression Potential]
Low - only the datatype is changed and an automated test is included.
---
unity::
Original description:
This issue, to me, is the same issue as https:/
ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: unity 3.8.16-
ProcVersionSign
Uname: Linux 2.6.38-8-generic x86_64
Architecture: amd64
CompizPlugins: [core,bailer,
CompositorRunning: compiz
CurrentDmesg:
[ 29.030016] eth0: no IPv6 routers present
[ 37.298652] EXT4-fs (sda1): re-mounted. Opts: errors=
[ 85.910008] CE: hpet2 increased min_delta_ns to 7500 nsec
[ 85.910015] CE: hpet2 increased min_delta_ns to 11250 nsec
[ 85.910018] hrtimer: interrupt took 3365 ns
Date: Tue Jul 5 16:29:05 2011
DistUpgraded: Fresh install
DistroCodename: natty
DistroVariant: ubuntu
GraphicsCard:
Intel Corporation 4 Series Chipset Integrated Graphics Controller [8086:2e12] (rev 03) (prog-if 00 [VGA controller])
Subsystem: Dell Device [1028:0420]
Subsystem: Dell Device [1028:0420]
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
InstallationMedia_: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
InstallationMed
MachineType: Dell Inc. OptiPlex 780
ProcEnviron:
LANGUAGE=en_US:en
PATH=(custom, user)
LANG=en_US.UTF-8
SHELL=/bin/bash
ProcKernelCmdLine: BOOT_IMAGE=
ProcVersionSign
ProcVersionSign
Renderer: Unknown
SourcePackage: unity
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 11/03/2010
dmi.bios.vendor: Dell Inc.
dmi.bios.version: A06
dmi.board.name: 0C27VV
dmi.board.vendor: Dell Inc.
dmi.board.version: A02
dmi.chassis.type: 6
dmi.chassis.vendor: Dell Inc.
dmi.modalias: dmi:bvnDellInc.
dmi.product.name: OptiPlex 780
dmi.sys.vendor: Dell Inc.
version.compiz: compiz 1:0.9.4+
version.ia32-libs: ia32-libs 20090808ubuntu13
version.libdrm2: libdrm2 2.4.23-1ubuntu6
version.
version.
version.
version.
version.
version.
version.
Related branches
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Stephen M. Webb (community): Approve
-
Diff: 322 lines (+72/-28)8 files modifieddash/previews/PreviewContainer.cpp (+1/-1)
launcher/Launcher.cpp (+14/-14)
launcher/SwitcherView.cpp (+3/-3)
plugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
tests/CMakeLists.txt (+1/-0)
tests/test_glib_source.cpp (+3/-3)
tests/test_time_util.cpp (+38/-0)
unity-shared/TimeUtil.h (+11/-6)
- Stephen M. Webb (community): Approve
-
Diff: 340 lines (+74/-30)8 files modifieddash/previews/PreviewContainer.cpp (+1/-1)
launcher/Launcher.cpp (+13/-13)
launcher/SwitcherView.cpp (+3/-3)
plugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
tests/CMakeLists.txt (+1/-0)
tests/test_glib_source.cpp (+6/-6)
tests/test_time_util.cpp (+38/-0)
unity-shared/TimeUtil.h (+11/-6)
- Stephen M. Webb (community): Disapprove
- Ubuntu Desktop: Pending requested
-
Diff: 3906 lines (+2970/-5) (has conflicts)37 files modifiedAUTHORS (+8/-0)
CMakeLists.txt (+15/-0)
ChangeLog (+280/-0)
manual-tests/QuicklistOnExpo.txt (+14/-0)
manual-tests/ReadMe.txt (+47/-0)
manual-tests/custom-dash-home/HomeShortcutsCustomized-4-entries.json (+22/-0)
manual-tests/custom-dash-home/HomeShortcutsCustomized-8-entries.json (+44/-0)
manual-tests/custom-dash-home/HomeShortcutsCustomized-broken.json (+23/-0)
manual-tests/custom-dash-home/custom-dash-home.txt (+46/-0)
manual-tests/launcher.txt (+14/-0)
plugins/unityshell/src/DashView.cpp (+57/-0)
plugins/unityshell/src/DashView.h (+11/-0)
plugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
plugins/unityshell/src/GeisAdapter.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+204/-0)
plugins/unityshell/src/LauncherIcon.cpp (+61/-0)
plugins/unityshell/src/LauncherIcon.h (+14/-0)
plugins/unityshell/src/PanelMenuView.cpp (+46/-0)
plugins/unityshell/src/PanelTray.cpp (+10/-0)
plugins/unityshell/src/PanelView.cpp (+5/-0)
plugins/unityshell/src/ScreenEffectFramebufferObject.cpp (+237/-0)
plugins/unityshell/src/ScreenEffectFramebufferObject.h (+87/-0)
plugins/unityshell/src/SwitcherController.cpp (+15/-0)
plugins/unityshell/src/SwitcherController.h (+1/-0)
plugins/unityshell/src/SwitcherModel.cpp (+7/-0)
plugins/unityshell/src/SwitcherView.cpp (+6/-2)
plugins/unityshell/src/TimeUtil.h (+17/-0)
plugins/unityshell/src/unityshell.cpp (+363/-1)
plugins/unityshell/src/unityshell.h (+75/-0)
tests/CMakeLists.txt (+444/-0)
tests/GLFuncLoader.cpp (+51/-0)
tests/GLFuncLoader.h (+33/-0)
tests/TestScreenEffectFramebufferObject.cpp (+671/-0)
tests/test-get-transients/CMakeLists.txt (+1/-0)
tests/test-input-remover/CMakeLists.txt (+1/-0)
tests/test-minimize-window-handler/CMakeLists.txt (+1/-0)
tests/test_time_util.cpp (+37/-0)
- Andrea Azzarone (community): Approve
-
Diff: 288 lines (+69/-26)6 files modifiedplugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+18/-18)
plugins/unityshell/src/SwitcherView.cpp (+3/-3)
plugins/unityshell/src/TimeUtil.h (+9/-4)
tests/CMakeLists.txt (+1/-0)
tests/test_time_util.cpp (+37/-0)
- Łukasz Zemczak: Approve
-
Diff: 269 lines (+67/-23)6 files modifiedplugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+13/-13)
plugins/unityshell/src/SwitcherView.cpp (+3/-3)
plugins/unityshell/src/TimeUtil.h (+11/-6)
tests/CMakeLists.txt (+1/-0)
tests/test_time_util.cpp (+38/-0)
- Ubuntu Desktop: Pending requested
-
Diff: 285 lines (+75/-23)7 files modifieddebian/changelog (+8/-0)
plugins/unityshell/src/ElapsedTimeMonitor.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+13/-13)
plugins/unityshell/src/SwitcherView.cpp (+3/-3)
plugins/unityshell/src/TimeUtil.h (+11/-6)
tests/CMakeLists.txt (+1/-0)
tests/test_time_util.cpp (+38/-0)
Changed in unity: | |
status: | New → Incomplete |
Changed in unity: | |
status: | Incomplete → Confirmed |
summary: |
- No icons shown in Unity launcher + Launcher icons are all rendered up in top left corner |
Changed in unity: | |
importance: | Undecided → Medium |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
Changed in unity: | |
status: | Triaged → Confirmed |
importance: | High → Medium |
summary: |
- Launcher icons are all rendered up in top left corner + Launcher icons are all rendered up in top left corner (happens after + long uptime) |
summary: |
- Launcher icons are all rendered up in top left corner (happens after - long uptime) + unity::TimeUtil::TimeDelta returns an int value which overflows after 24 + days of uptime |
description: | updated |
Changed in unity: | |
assignee: | nobody → Unity Maintainers (unity-maintainers-team) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Unity Maintainers (unity-maintainers-team) |
Changed in unity: | |
assignee: | Unity Maintainers (unity-maintainers-team) → Brandon Schaefer (brandontschaefer) |
status: | Triaged → Won't Fix |
status: | Won't Fix → In Progress |
Changed in unity (Ubuntu): | |
assignee: | Unity Maintainers (unity-maintainers-team) → Brandon Schaefer (brandontschaefer) |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | Triaged → Fix Committed |
description: | updated |
Changed in unity (Ubuntu Quantal): | |
assignee: | nobody → Timo Jyrinki (timo-jyrinki) |
status: | New → In Progress |
milestone: | none → quantal-updates |
tags: | added: precise |
Changed in unity (Ubuntu Precise): | |
importance: | Undecided → High |
Changed in unity (Ubuntu Precise): | |
assignee: | nobody → Chris J Arges (arges) |
Changed in unity (Ubuntu Precise): | |
milestone: | none → precise-updates |
Changed in unity (Ubuntu Quantal): | |
importance: | Undecided → High |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Released → Fix Committed |
I've taken a screenshot. Notice that when I hover over the location where the icon should be, its title shows up.