[SRU] xfce4-power-manager does not inhibit systemd from handling buttons and lid events
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Xfce4 Power Manager |
Fix Released
|
Medium
|
|||
xfce4-power-manager (Debian) |
New
|
Unknown
|
|||
xfce4-power-manager (Ubuntu) |
Fix Released
|
Medium
|
Jackson Doak | ||
Saucy |
Fix Released
|
Medium
|
Unassigned | ||
Trusty |
Fix Released
|
Medium
|
Jackson Doak |
Bug Description
[Impact]
High. All users with laptops are affected.
The Laptop sleeps when lid is closed, regardless of Power Manager settings. This also occurs in the Live install where Sleep is not even an option for lid closure actions.
[Test Case]
Close the lid of any laptop running xubuntu, lubuntu or ubuntu studio 13.10.
The device will go to sleep regardless of xfce4-power-
Please also test that upower suspend/hibernate still works.
[Regression potential]
Low. The patch has been extensively tested is Xubuntu, SUSE, Debian, and upstream.
This change doesn't affect external packages.
[Patch]
Merge lp:~noskcaj/ubuntu/saucy/xfce4-power-manager/systemd
This contains two patches and enables dh-autoreconf to force xdt-autogen to run.
[Original Bug]
Laptop sleeps when lid is closed, regardless of Power Manager settings. This also occurs in the Live install where Sleep is not even an option for lid closure actions. Confirmed in Ubuntu Studio 13.10 Beta 1 x64 and Xubuntu 13.10 Beta 1. Does not occur in Ubuntu Studio 13.04.
WORKAROUND: This can be adjusted in /etc/systemd/
ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: xfce4-power-manager 1.2.0-2ubuntu1
ProcVersionSign
Uname: Linux 3.11.0-2-lowlatency x86_64
ApportVersion: 2.12.1-0ubuntu3
Architecture: amd64
CasperVersion: 1.336
Date: Sat Sep 7 04:34:32 2013
LiveMediaBuild: Ubuntu-Studio 13.10 "Saucy Salamander" - Alpha amd64 (20130902)
MarkForUpload: True
SourcePackage: xfce4-power-manager
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Daniel Holbach (community): Approve
-
Diff: 13750 lines (+2096/-11299)33 files modified.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/po/POTFILES.in (+0/-19)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/Makefile.am (+0/-211)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/gsd-media-keys-window.c (+0/-1078)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/gsd-media-keys-window.h (+0/-71)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/xfpm-backlight.c (+0/-478)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/xfpm-notify.c (+0/-409)
.pc/02_translations-fix-invalid-format-strings.patch/po/en_GB.po (+0/-1083)
.pc/02_translations-fix-invalid-format-strings.patch/po/te.po (+0/-1061)
.pc/02_translations-fix-invalid-format-strings.patch/po/tr.po (+0/-1486)
.pc/03_fix-insert-battery.patch/src/xfpm-battery.c (+0/-916)
.pc/03_fix-insert-battery.patch/src/xfpm-power.c (+0/-1755)
.pc/04_fix-missing-icons-for-non-system-batteries.patch/src/xfpm-battery.c (+0/-918)
.pc/06_fix-suspend-auth-check.patch/src/xfpm-power.c (+0/-1756)
.pc/08_show_preferences_lxde.patch/settings/xfce4-power-manager-settings.desktop.in (+0/-14)
.pc/applied-patches (+0/-6)
debian/changelog (+7/-0)
debian/patches/05_dont-allow-systemd-to-handle-suspend-hibernate-events.patch (+126/-0)
debian/patches/06_add-shutdown-reboot-functionality-for-systemd.patch (+635/-0)
debian/patches/06_fix-suspend-auth-check.patch (+7/-5)
debian/patches/series (+3/-1)
debian/rules (+3/-0)
po/POTFILES.in (+0/-1)
po/en_GB.po (+4/-2)
po/te.po (+20/-0)
po/tr.po (+20/-0)
settings/xfce4-power-manager-settings.desktop.in (+1/-1)
src/Makefile.am (+3/-1)
src/gsd-media-keys-window.c (+1078/-0)
src/gsd-media-keys-window.h (+71/-0)
src/xfpm-backlight.c (+113/-19)
src/xfpm-battery.c (+3/-5)
src/xfpm-notify.c (+1/-1)
src/xfpm-power.c (+1/-2)
- Micah Gersten (community): Disapprove
-
Diff: 13764 lines (+2097/-11300)34 files modified.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/po/POTFILES.in (+0/-19)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/Makefile.am (+0/-211)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/gsd-media-keys-window.c (+0/-1078)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/gsd-media-keys-window.h (+0/-71)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/xfpm-backlight.c (+0/-478)
.pc/01_Remove_custom_OSD_brightness_popup,_use_libnotify_instead.patch/src/xfpm-notify.c (+0/-409)
.pc/02_translations-fix-invalid-format-strings.patch/po/en_GB.po (+0/-1083)
.pc/02_translations-fix-invalid-format-strings.patch/po/te.po (+0/-1061)
.pc/02_translations-fix-invalid-format-strings.patch/po/tr.po (+0/-1486)
.pc/03_fix-insert-battery.patch/src/xfpm-battery.c (+0/-916)
.pc/03_fix-insert-battery.patch/src/xfpm-power.c (+0/-1755)
.pc/06_fix-suspend-auth-check.patch/src/xfpm-power.c (+0/-1756)
.pc/08_show_preferences_lxde.patch/settings/xfce4-power-manager-settings.desktop.in (+0/-14)
.pc/applied-patches (+0/-6)
.pc/xubuntu_fix-status-icon-other-devices.patch/src/xfpm-battery.c (+0/-918)
debian/changelog (+7/-0)
debian/control (+1/-1)
debian/patches/05_dont-allow-systemd-to-handle-suspend-hibernate-events.patch (+126/-0)
debian/patches/06_add-shutdown-reboot-functionality-for-systemd.patch (+635/-0)
debian/patches/06_fix-suspend-auth-check.patch (+7/-5)
debian/patches/series (+2/-0)
debian/rules (+4/-1)
po/POTFILES.in (+0/-1)
po/en_GB.po (+4/-2)
po/te.po (+20/-0)
po/tr.po (+20/-0)
settings/xfce4-power-manager-settings.desktop.in (+1/-1)
src/Makefile.am (+3/-1)
src/gsd-media-keys-window.c (+1078/-0)
src/gsd-media-keys-window.h (+71/-0)
src/xfpm-backlight.c (+113/-19)
src/xfpm-battery.c (+3/-5)
src/xfpm-notify.c (+1/-1)
src/xfpm-power.c (+1/-2)
description: | updated |
Changed in xfce4-power-manager (Debian): | |
status: | Unknown → New |
summary: |
- Laptop sleeps when lid is closed, regardless of Power Manager Settings. + xfce4-power-manager does not inhibit systemd from handling buttons and + lid events |
Changed in xfce4-power-manager (Ubuntu): | |
importance: | Undecided → Medium |
status: | Confirmed → Triaged |
description: | updated |
tags: |
added: trusty removed: needs-duplicate-check |
tags: | added: xubuntu |
description: | updated |
Changed in xfce4-power-manager (Ubuntu): | |
status: | Triaged → In Progress |
assignee: | nobody → Jackson Doak (noskcaj) |
Changed in xfce4-power-manager (Ubuntu Saucy): | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in xfce4-power-manager (Ubuntu Saucy): | |
assignee: | nobody → Jackson Doak (noskcaj) |
status: | Triaged → In Progress |
summary: |
- xfce4-power-manager does not inhibit systemd from handling buttons and - lid events + [SRU] xfce4-power-manager does not inhibit systemd from handling buttons + and lid events |
description: | updated |
description: | updated |
Changed in xfce4-power-manager: | |
importance: | Unknown → Medium |
Changed in xfce4-power-manager (Ubuntu Saucy): | |
assignee: | Micah Gersten (micahg) → nobody |
status: | In Progress → Triaged |
status: | Triaged → Fix Committed |
Changed in xfce4-power-manager (Ubuntu Saucy): | |
importance: | High → Medium |
Changed in xfce4-power-manager: | |
status: | Unknown → Fix Released |
This may be marked a dupe of https:/ /bugzilla. xfce.org/ show_bug. cgi?id= 9326
(This could be handled in xfce4-session by calling systemd-inhibit on session start, but could be solved here by calling the dbus calls to inhibit systemd when xfce4-power-manager is actually running).
As of systemd version 190, systemd now takes over handling lid button, power and sleep buttons, etc. manager. It would be nice if xfce4 session could inhibit this on startup.
This overrides xfce4-power-
From the systemd NEWS file:
" * logind's inhibition logic has been updated. By default,
handle- power-key, handle-sleep-key and handle-lid-switch
inhibitors during their runtime. A simple way to achiveve
logind will now handle the lid switch, the power and sleep
keys all the time, even in graphical sessions. If DEs want
to handle these events on their own they should take the new
that is to invoke the DE wrapped in an invocation of:
See also: http:// www.freedesktop .org/wiki/ Software/ systemd/ inhibit
It may be that xfce4-power-manager should take this instead of xfce4-session... which would allow for systemd to handle things still in cases where xfce4-power-manager was not running.