Comment 0 for bug 1751986

== Comment: #5 - Pridhiviraj Paidipeddi <email address hidden> - 2018-02-26 11:02:21 ==
We are missing Product Version in lsmcode output, due to which "lsmcode -A" fails.
lsmcode(incorrect output)
=================
Version of System Firmware :
 Product Name : OpenPOWER Firmware
 Product Extra : occ-fce2d94
 Product Extra : skiboot-v5.9-238-g43eb8bbcbaa5
 Product Extra : buildroot-2017.11-5-g65679be
 Product Extra : capp-ucode-p9-dd2-v2
 Product Extra : petitboot-v1.6.6-p91994c3
 Product Extra : sbe-86ae83c
 Product Extra : hostboot-binaries-8b5adb5
 Product Extra : machine-xml-4374657
 Product Extra : hostboot-52ca812
 Product Extra : linux-4.14.13-openpower1-pdb952b4

lsmcode(correect output)
================
Version of System Firmware :
 Product Name : OpenPOWER Firmware
 Product Version : open-power-SUPERMICRO-P9DSU-V1.03-20180205-imp
 Product Extra : occ-577915f
 Product Extra : skiboot-v5.9-240-g081882690163-pcbedce4
 Product Extra : petitboot-v1.6.6-p019c87e
 Product Extra : sbe-095e608
 Product Extra : machine-xml-fb5f933
 Product Extra : hostboot-9bfb201
 Product Extra : linux-4.14.13-openpower1-p78d7eee

So we need two fixes here, one is to form Product Version string and another one is to fix "lsmcode -A" empty output bug when there is no Product Version available.

== Comment: #6 - Pridhiviraj Paidipeddi <email address hidden> - 2018-02-26 11:10:23 ==
Attached patch will fix "lsmcode -A" empty output issue.

[root@ltc-wspoon2 lsvpd]# ./lsmcode -A
enP5p1s0f0 !.5719-v1.43 NCSI v1.3.12.0
enP5p1s0f1 !.5719-v1.43 NCSI v1.3.12.0
sg0 0:0:0:0 sda !ST1000NX0313.BE35
sg1 1:0:0:0 sdb !ST1000NX0313.BE35
[root@ltc-wspoon2 lsvpd]# ./lsmcode -v
lsmcode 1.7.8
[root@ltc-wspoon2 lsvpd]# ./lsmcode
Version of System Firmware :
 Product Name : OpenPOWER Firmware
 Product Extra : occ-fce2d94
 Product Extra : skiboot-v5.9-238-g43eb8bbcbaa5
 Product Extra : buildroot-2017.11-5-g65679be
 Product Extra : capp-ucode-p9-dd2-v2
 Product Extra : petitboot-v1.6.6-p91994c3
 Product Extra : sbe-86ae83c
 Product Extra : hostboot-binaries-8b5adb5
 Product Extra : machine-xml-4374657
 Product Extra : hostboot-52ca812
 Product Extra : linux-4.14.13-openpower1-pdb952b4

Tested on a AC922 system where the failure occurs when it is having a firmware OP920.