Prevent segfault immediately after install when zfs kernel module isn't loaded

Bug #1881541 reported by Didier Roche on 2020-06-01
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zsys (Ubuntu)
Low
Didier Roche
Focal
Low
Didier Roche

Bug Description

[Impact]
* People building or installing their own custom kernel without the ZFS module built-in were impacted: they were installing zsys and postinst was segfaulting.

[Test Case]
1. Have a custom kernel without the ZFS module built-in
2. Install ZSys: no segfault should be reported.

[Regression Potential]
This is an edge case for some users going out of ubuntu support, but we still make their lives better.

Note that this doesn’t impact people with traditional ext4 system running ubuntu kernel and installing ZSys, as this was already handled.

Colin Ian King (colin-king) wrote :

Didier, what segfaults? Is this zsys issue or a zfsutils issue? If it's a zsys issue perhaps we can tag this so as I'm trying to differentiate between zsys, zfs utils userspace and kernel bugs when triaging these issues.

Changed in zfs-linux (Ubuntu):
status: New → Incomplete
importance: Undecided → Medium
Didier Roche (didrocks) wrote :

Sorry Colin, this was ZSys and I targetted the wrong component when filing batch-bugs for ZSys 0.5 upload.

Fixed in https://launchpad.net/ubuntu/+source/zsys/0.5.0.

affects: zfs-linux (Ubuntu) → zsys (Ubuntu)
Changed in zsys (Ubuntu):
status: Incomplete → Fix Released
Colin Ian King (colin-king) wrote :

Cool, no problem. Thanks for the update.

Didier Roche (didrocks) on 2020-06-09
description: updated
Changed in zsys (Ubuntu):
importance: Medium → Low
assignee: nobody → Didier Roche (didrocks)
Changed in zsys (Ubuntu Focal):
importance: Undecided → Low
assignee: nobody → Didier Roche (didrocks)

Hello Didier, or anyone else affected,

Accepted zsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zsys/0.4.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in zsys (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Focal:
I have reproduced the problem with zsys 0.4.5 in focal and have verified that the version of zsys 0.4.6 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zsys - 0.4.6

---------------
zsys (0.4.6) focal; urgency=medium

  [ Jean-Baptiste Lallement ]
  [ Didier Roche ]
  * Fix infinite GC loop (LP: #1870461)
  * Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
    desc = context deadline exceeded while the daemon is doing work
    (LP: #1875564)
  * Stop taking automated or manual snapshot when there is less than 20% of
    free disk space (LP: #1876334)
  * Enable trim support for upgrading users (LP: #1881540)
  * Only clean up previously linked user datasets when unlinked under USERDATA
    (LP: #1881538)
  * Strategy for deleted user datasets via a new hidden command called by
    userdel (LP: #1870058)
  * Get better auto snapshots message when integrated to apt (LP: #1875420)
  * Update LastUsed on shutdown via a new hidden command service call
    (LP: #1881536)
  * Prevent segfault immediately after install when zfs kernel module isn't
    loaded (LP: #1881541)
  * Don’t try to autosave gdm user (and in general non system user), even if
    systemd --user is started for them. (LP: #1881539)
  * Prevent apt printing errors when zsys is removed without purge
    (LP: #1881535)
  * Some tests enhancements:
    - new tests for all the above
    - allow setting a different local socket for debugging/tests purposes only
    - ascii order datasets in golden files
  * Typos and messages fixes. Direct prints are not prefixed with INFO
    anymore.
  * Refreshed po and readme with the above.

 -- Didier Roche <email address hidden> Mon, 01 Jun 2020 09:26:52 +0200

Changed in zsys (Ubuntu Focal):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for zsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers