Enable trim support for upgrading users
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zsys (Ubuntu) |
Fix Released
|
Undecided
|
Didier Roche-Tolomelli | ||
Focal |
Fix Released
|
Low
|
Didier Roche-Tolomelli |
Bug Description
[Impact]
* Autotrim (a fresh feature in 0.8) hasn’t been enabled on purpose on new ZFS installation.
* Now that we personnaly ran it on our SSD for some weeks, we have been able to experiement it and test its robustness (empirically)
* We need to enable it so that users with SSD don’t suffer from performance degration over time, as in traditional ubuntu which has trim supported.
[Test Case]
1. zpool status -t <pool> -> the pool was never trim.
2. zpool get autotrim <pool> -> should be off
3. Install ZSys update
4. zpool status -t <pool> -> trimming is done or in progress.
5. zpool get autotrim <pool> -> should be on
[Regression Potential]
* The upgrade set autotrim on both rpool and bpool (and only on them) to not impact other pools.
* As autotrim is only for new write, we issue a manual zpool trim commands over them, which is ran in background by the kernel zfs module. The commands exits immediately.
* We also tested installations without bpool.
Changed in zsys (Ubuntu): | |
assignee: | nobody → Didier Roche (didrocks) |
description: | updated |
Changed in zsys (Ubuntu Focal): | |
status: | New → Triaged |
importance: | Undecided → Low |
assignee: | nobody → Didier Roche (didrocks) |
This bug was fixed in the package zsys - 0.5.0
---------------
zsys (0.5.0) groovy; urgency=medium
[ Jean-Baptiste Lallement ]
[ Didier Roche ]
* Fix infinite GC loop (LP: #1870461)
* Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
desc = context deadline exceeded while the daemon is doing work
(LP: #1875564)
* Stop taking automated or manual snapshot when there is less than 20% of
free disk space (LP: #1876334)
* Enable trim support for upgrading users (LP: #1881540)
* Only clean up previously linked user datasets when unlinked under USERDATA
(LP: #1881538)
* Strategy for deleted user datasets via a new hidden command called by
userdel (LP: #1870058)
* Get better auto snapshots message when integrated to apt (LP: #1875420)
* Update LastUsed on shutdown via a new hidden command service call
(LP: #1881536)
* Prevent segfault immediately after install when zfs kernel module isn't
loaded (LP: #1881541)
* Don’t try to autosave gdm user (and in general non system user), even if
systemd --user is started for them. (LP: #1881539)
* Prevent apt printing errors when zsys is removed without purge
(LP: #1881535)
* Some tests enhancements:
- new tests for all the above
- allow setting a different local socket for debugging/tests purposes only
- ascii order datasets in golden files
* Typos and messages fixes. Direct prints are not prefixed with INFO
anymore.
* Refreshed po and readme with the above.
-- Didier Roche <email address hidden> Mon, 01 Jun 2020 09:26:52 +0200