Unmanaged datasets destroyed at boot time after import of zpool.cache
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
zsys (Ubuntu) |
Fix Released
|
High
|
Didier Roche-Tolomelli | ||
Focal |
Fix Released
|
High
|
Didier Roche-Tolomelli |
Bug Description
[Impact]
* People creating manually datasets under the reserved namespace /USERDATA/ were considered good to clean up by ZSys and were removed.
* Even if this namespace shouldn’t be used by user, mitigate by preventing GC to collect and destroy them.
* Mark them differently to ZSys user datasets that were untagged so that those last ones are still considered for cleanup
* This is covered by dedicated use cases.
[Test Case]
1. zfs create rpool/USERDATA/foo
2. Run zsysctl service GC
3. Check that rpool/USERDATA/foo hasn’t been collected.
[Regression Potential]
* The clean up was too extreme for those edge cases users.
* GC is a separate, timer-based process and don’t impact boot or other operations.
* The 30 existing tests on the GC didn’t regress and we now have some additional ones around those use case.
-----
This was reported as https:/
Don’t remove anything that is under /USERDATA/ if this wasn’t a fully zsys unlinked user state (with every other states unlinked as well)
description: | updated |
description: | updated |
description: | updated |
Changed in zsys (Ubuntu): | |
assignee: | nobody → Didier Roche (didrocks) |
importance: | Undecided → High |
Changed in zsys (Ubuntu Focal): | |
assignee: | nobody → Didier Roche (didrocks) |
importance: | Undecided → High |
This bug was fixed in the package zsys - 0.5.0
---------------
zsys (0.5.0) groovy; urgency=medium
[ Jean-Baptiste Lallement ]
[ Didier Roche ]
* Fix infinite GC loop (LP: #1870461)
* Enhance timeout handling to avoid error rpc error: code = DeadlineExceeded
desc = context deadline exceeded while the daemon is doing work
(LP: #1875564)
* Stop taking automated or manual snapshot when there is less than 20% of
free disk space (LP: #1876334)
* Enable trim support for upgrading users (LP: #1881540)
* Only clean up previously linked user datasets when unlinked under USERDATA
(LP: #1881538)
* Strategy for deleted user datasets via a new hidden command called by
userdel (LP: #1870058)
* Get better auto snapshots message when integrated to apt (LP: #1875420)
* Update LastUsed on shutdown via a new hidden command service call
(LP: #1881536)
* Prevent segfault immediately after install when zfs kernel module isn't
loaded (LP: #1881541)
* Don’t try to autosave gdm user (and in general non system user), even if
systemd --user is started for them. (LP: #1881539)
* Prevent apt printing errors when zsys is removed without purge
(LP: #1881535)
* Some tests enhancements:
- new tests for all the above
- allow setting a different local socket for debugging/tests purposes only
- ascii order datasets in golden files
* Typos and messages fixes. Direct prints are not prefixed with INFO
anymore.
* Refreshed po and readme with the above.
-- Didier Roche <email address hidden> Mon, 01 Jun 2020 09:26:52 +0200