Comment 1 for bug 1799498

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

So currently, without any modifications, the new walinuxagent packages (based on 2.2.32) fail to build due to failing unit-tests. Apparently for all the previous walinuxagent versions in Ubuntu, no unit-tests have been running during build because of a bug in setup.py (fixed recently in PR #1244 [1]). Only now we actually see the tests running. I did a similar change to the current cosmic package and also saw many similar failures.

Were all the walinuxagent unit-tests expected to pass on Ubuntu? Some tests will obviously fail (like the cgroup ones) because of the builder environment, but there's also a lot of others that I wouldn't normally expect to fail - but they're failing on the new and old walinuxagent.

Possibly what we'll do is ignore the failures for this release (it's a possibility), unless the expectation was that those should have been passing already. For the next release we would really need to have those passing though. Maybe move out some of them (like the cgroup ones) as autopkgtests, since only then they could actually work.

What's the case here?

[1] https://github.com/Azure/WALinuxAgent/pull/1244